Change InitClass and InitInstantiatedClass to return void* for WASM portable entry point compatibility#131119
Merged
Merged
Conversation
…ortable entry point compatibility Co-authored-by: davidwrighton <10779849+davidwrighton@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
davidwrighton
July 21, 2026 00:09
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Open
3 tasks
davidwrighton
approved these changes
Jul 21, 2026
davidwrighton
marked this pull request as ready for review
July 21, 2026 17:30
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
I think this requires something like #130813 as a follow up otherwise you'll end up with signature mismatches. |
lewing
approved these changes
Jul 21, 2026
lewing
left a comment
lewing
left a comment
Member
There was a problem hiding this comment.
LGTM with the caveat that the various class init helpers need the same change, see linked pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the
InitHelpers.cschanges from AndyAyersMS:runtime:next-blocker-spc. On WASM targets using portable entry points,call_indirectsignatures must match the compiled method exactly including return arity — but the JIT already models these helpers as value-returning (result pushed then discarded). Fix: return a dummynullfrom both helpers.InitClass:void→void*, invert condition (remove early return), addreturn nullInitInstantiatedClass: same treatmentcall_indirectABI requirement