Re-enable BitOps_Crc32C_* tests on tvOS#130560
Conversation
Co-authored-by: tannergooding <10487869+tannergooding@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR re-enables the BitOps_Crc32C_* test coverage on tvOS by removing tvOS-specific [ActiveIssue] skips from four CRC32C theory tests in System.Runtime.Extensions.Tests.
Changes:
- Removed tvOS
[ActiveIssue]skip fromBitOps_Crc32C_byte. - Removed tvOS
[ActiveIssue]skip fromBitOps_Crc32C_ushort,BitOps_Crc32C_uint, andBitOps_Crc32C_ulong.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Numerics/BitOperationsTests.cs | Drops tvOS-only [ActiveIssue] skips so the CRC32C test cases run on tvOS again. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
|
@kotlarmilos is runtime-ioslike right for this one too or is there a different leg needed for specifically tvos? |
|
/azp run runtime-ioslike |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Yes, it is enough, consider it as Apple mobile. We use separate queues because capacity differs and we need to balance load, but treat runtime-ioslike as covering both, since the platforms are the same (or very similar) |
|
Workflow state for the Holistic Review Orchestrator. {
"version": 5,
"last_dispatched_commit": "b6e61a0e6457a4986884312e07c5ca2d28777b85",
"last_dispatched_base_ref": "main",
"last_dispatched_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_reviewed_commit": "b6e61a0e6457a4986884312e07c5ca2d28777b85",
"last_reviewed_base_ref": "main",
"last_reviewed_base_sha": "a7ed27ba3f7a0a32634be47079ac659909797806",
"last_recorded_worker_run_id": "29682986224",
"review_attempt_commit": "",
"review_attempt_base_ref": "",
"review_attempt_count": 0,
"max_review_attempts": 5,
"review_history_format": "holistic-review-disclosure-v1",
"review_history": [
{
"commit": "b6e61a0e6457a4986884312e07c5ca2d28777b85",
"review_id": 4730586274
}
]
} |
There was a problem hiding this comment.
Holistic Review
Motivation: The four BitOps_Crc32C_* tests in BitOperationsTests.cs were skipped on tvOS via [ActiveIssue(...76830, TestPlatforms.tvOS)] after a native crash in BitOps_Crc32C_byte on tvOS arm64 (issue #76830). Per the tracking issue's agent instructions, this PR removes those skips to let the runtime-extra-platforms tvOS leg confirm whether the crash still reproduces on current CI.
Approach: Purely a test change. It deletes the [ActiveIssue] attribute from BitOps_Crc32C_byte, BitOps_Crc32C_ushort, BitOps_Crc32C_uint, and BitOps_Crc32C_ulong, leaving the [Theory]/[InlineData] cases and assertions untouched. No production code is affected. This is the correct, minimal, and reversible way to re-validate a platform-specific ActiveIssue: if the crash reappears, the annotations (and the issue) should be restored/reopened for root-cause work rather than left green.
Summary: The diff is clean, complete, and low-risk. All four annotated tests had their tvOS skip removed consistently, matching the PR description and the referenced issue #76830. The change is easy to revert if the tvOS leg still crashes. Because the value of this PR depends entirely on the runtime-extra-platforms tvOS result, the merge decision should be gated on that leg being green; a crash there means the skips must be reinstated instead of merged. No code-level issues found. Verdict: LGTM (test-only, contingent on the tvOS CI leg passing).
Note
This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.
Generated by Holistic Review · 54.4 AIC · ⌖ 10.1 AIC · ⊞ 10K
Per agent instructions on the tracking issue, remove the tvOS
[ActiveIssue]skips from the fourBitOps_Crc32C_*tests to check whether the original crash still reproduces on current tvOS CI.[ActiveIssue("https://github.com/dotnet/runtime/issues/76830", TestPlatforms.tvOS)]fromBitOps_Crc32C_byte,BitOps_Crc32C_ushort,BitOps_Crc32C_uint, andBitOps_Crc32C_ulonginsrc/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Numerics/BitOperationsTests.cs.No production code touched — the runtime-extra-platforms tvOS leg will confirm whether the crash still reproduces. If it does, the attributes should be restored (and the issue reopened for root-cause).