[main] Source code updates from dotnet/dotnet#128956
Open
dotnet-maestro[bot] wants to merge 8 commits into
Open
[main] Source code updates from dotnet/dotnet#128956dotnet-maestro[bot] wants to merge 8 commits into
dotnet-maestro[bot] wants to merge 8 commits into
Conversation
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.BannedApiAnalyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.8.0-1.26266.103 -> 5.9.0-1.26302.118) Microsoft.CodeAnalysis.NetAnalyzers, Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-11.0.100.Transport (Version 11.0.100-preview.5.26257.113 -> 11.0.100-preview.6.26302.118) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 11.0.0-beta.26257.113 -> 11.0.0-beta.26302.118) Microsoft.DotNet.Cecil (Version 0.11.5-preview.26257.113 -> 0.11.5-preview.26302.118) Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.26257.113 -> 2.9.3-beta.26302.118) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 11.0.0-preview.5.26257.113 -> 11.0.0-preview.6.26302.118) NuGet.Frameworks, NuGet.Packaging, NuGet.ProjectModel, NuGet.Versioning (Version 7.7.0-rc.25813 -> 7.9.0-rc.30318) System.CommandLine (Version 3.0.0-preview.5.26257.113 -> 3.0.0-preview.6.26302.118) runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.osx-arm64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.osx-x64.Microsoft.NETCore.Runtime.JIT.Tools, runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools, runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Libclang, runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk, runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools (Version 19.1.0-alpha.1.26208.2 -> 19.1.0-alpha.1.26256.1) runtime.linux-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.linux-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.osx-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.osx-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.win-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport, runtime.win-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport (Version 11.0.0-alpha.1.26208.5 -> 11.0.0-alpha.1.26279.1) [[ commit created by automation ]]
dotnet-maestro
Bot
requested review from
MichalStrehovsky,
steveisok and
vitek-karas
as code owners
Roslyn (dotnet/roslyn#83813) added two new hard errors for malformed [UnionAttribute] usage: CS9385: A union type must have at least one union creation member. CS9386: A union member provider type must have a public instance 'Value' property of type 'object?' or 'object'. Hard errors cannot be suppressed via #pragma warning disable, so the two C# test types that deliberately violated these rules no longer compile. Remove the now-uncompilable types and their associated tests, and drop the matching [JsonSerializable] entries from the source-gen contexts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ensure test classes have a single public parameterless constructor as required by xUnit1056. For classes with only private/internal constructors, add a public parameterless constructor. For structs with explicit constructors (GitHub_19537 Matrix4x4), move [Fact] to a separate wrapper class. For ContextualReflection.Program which had two public constructors, make the non-default one internal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit c572809)
For classes with only private constructors (instance.cs, gcreport.cs, twoEndFinallys.cs, pidigits-3.cs, arrres.cs): ensure a public parameterless constructor exists so xUnit can instantiate the test class. For structs with multiple public constructors (ctor_recurse.cs, han3_ctor.cs, han3_ref.cs): move [Fact] methods to separate wrapper classes since structs inherently have an implicit parameterless constructor plus any explicit ones, causing ambiguity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit fbb7a07)
Ensure each test class has exactly one public non-static constructor as required by the xUnit1056 rule: - CollectionCountTest: make parameterless constructor public - ClosedStatic: add public parameterless constructor (keep private parameterized one to avoid xUnit1041) - NDPin: add public parameterless constructor (keep internal parameterized one to avoid xUnit1041) - RootMem: add public parameterless constructor (keep private parameterized one to avoid xUnit1041) - ReflectObj: make ReflectObj(int) constructor internal (was two public constructors), update Activator.CreateInstance call to use BindingFlags and DynamicallyAccessedMembers annotation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 2f89594)
…tensions (cherry picked from commit 48f9d87)
Remove Ranges(int[]) and BinaryRanges(int[], int[]) overloads from Sources and UnorderedSources that were simple wrappers delegating to their IEnumerable<int> counterparts. Since int[] implements IEnumerable<int>, xUnit MemberData could not disambiguate between the two, producing xUnit1065 analyzer errors. The IEnumerable<int> overloads handle int[] arguments directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 11dc266)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch