[ci-scan] Improve test-disable prompt: ActiveIssue overload and referenced-issue checks#128760
Open
kotlarmilos wants to merge 1 commit into
Open
Conversation
…enced-issue do-not-disable check Three edits to .github/workflows/ci-failure-scan.md proposed by the ci-failure-scan-feedback meta-loop (dotnet#128755): - Step 4.7: also read the body + latest 5 comments of any issue referenced in the KBE body, so maintainer 'do not disable' / 'will investigate' signals on the root-cause issue override the KBE candidate. Motivated by dotnet#128737, where the signal lived on the referenced root-cause issue, not the KBE. - Document the full 4-parameter ActiveIssue overload (string, TestPlatforms, TargetFrameworkMonikers, TestRuntimes) with an explicit warning not to put a TestRuntimes value in the TargetFrameworkMonikers slot. Motivated by dotnet#128469, which failed to compile because of this exact swap. - Add a pre-emit compile-validation checklist for test-disable PRs. Closes dotnet#128755. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
Prompt-only edits to the CI failure scanner workflow to (a) detect "do-not-disable" signals on root-cause issues referenced by a candidate KBE, (b) document the full 4-parameter ActiveIssue overload to prevent positional argument errors, and (c) add a pre-emit compile-validation checklist for test-disable PRs.
Changes:
- Step 4.7 now also reads referenced root-cause issues (e.g.
refs #N) for maintainer signals. - Documents the
ActiveIssue(string, TestPlatforms, TargetFrameworkMonikers, TestRuntimes)overload with explicit warning against slot swaps. - Adds a 3-item pre-emit compile-validation checklist.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-failure-scan.md |
Strengthens Step 4.7 do-not-disable detection, documents the 4-parameter ActiveIssue overload, and adds a compile-validation checklist. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
kotlarmilos
changed the title
kotlarmilos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three prompt edits to
.github/workflows/ci-failure-scan.mdproposed by the ci-failure-scan-feedback meta-loop in #128755. Step 4.7 now also reads the body and latest 5 comments of any issue referenced in the KBE, so maintainer "do not disable" signals on the root-cause issue override the KBE candidate (motivated by #128737). TheActiveIssuesection gains the full 4-parameter overload(string, TestPlatforms, TargetFrameworkMonikers, TestRuntimes)with an explicit warning not to place aTestRuntimesvalue in theTargetFrameworkMonikersslot (motivated by #128469, which failed to compile from that exact swap). A short pre-emit compile-validation checklist is added for test-disable PRs. Nogh aw compileneeded: the scanner workflow loads this file at runtime via{{#runtime-import}}. Closes #128755.