Add AddRegisteredId to SubjectAlternativeNameBuilder#126900
Merged
vcsjones merged 1 commit intodotnet:mainfrom Apr 15, 2026
Merged
Add AddRegisteredId to SubjectAlternativeNameBuilder#126900vcsjones merged 1 commit intodotnet:mainfrom
vcsjones merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for adding a Registered ID (OID) GeneralName to SubjectAlternativeNameBuilder, enabling Subject Alternative Name (SAN) construction scenarios that require registeredID entries.
Changes:
- Added
SubjectAlternativeNameBuilder.AddRegisteredId(string registeredId)API. - Added unit tests covering argument validation, valid encoding, invalid OID handling, and mixed multi-value SANs.
- Updated the reference assembly to expose the new public API.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/SubjectAlternativeNameBuilder.cs | Adds the new AddRegisteredId API and routes it through GeneralNameAsn.RegisteredId. |
| src/libraries/System.Security.Cryptography/tests/X509Certificates/CertificateCreation/SubjectAltNameBuilderTests.cs | Adds coverage for registered ID encoding and invalid OID input behavior. |
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Exposes AddRegisteredId(string) in the public ref surface. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
bartonjs
approved these changes
Apr 14, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125127