Use Checked runtime for cDAC dump tests#126899
Merged
max-charlamb merged 2 commits intodotnet:mainfrom Apr 15, 2026
Merged
Conversation
Switch dump test builds from Release to Checked runtime configuration (-rc checked) while keeping libs as Release (-lc release). This enables runtime asserts in the CLR, which helps catch issues in the cDAC data descriptors and contract implementations during dump testing. Affects single-leg, xplat dump gen, and xplat dump test stages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ThreadStore.FirstThreadLink: SLink -> T_POINTER (SLink is a single-pointer struct; managed code reads the pointer directly) - Thread.LastThrownObject: GCHandle -> T_POINTER (OBJECTHANDLE is a pointer type; managed code reads it as a pointer) - Array.m_NumComponents: T_POINTER -> T_UINT32 (native type is DWORD) All three were caught by Debug.Assert in TargetFieldExtensions when running dump tests with a Checked runtime build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
max-charlamb
requested review from
barosiak,
Copilot,
hoyosjs,
noahfalk and
rcj1
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This was referenced Apr 15, 2026
steveisok
approved these changes
Apr 15, 2026
hoyosjs
approved these changes
Apr 15, 2026
Member
Author
|
/ba-g test failures unrelated to cDAC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was created with assistance from GitHub Copilot.
Switch the cDAC dump test builds from Release to Checked runtime configuration (
-rc checked) while keeping libs as Release (-lc release). This enables runtime asserts in the CLR, which helps catch issues in the cDAC data descriptors and contract implementations during dump testing.Changes:
-rc release→-rc checked-rc release→-rc checked-rc release→-rc checkedSOS test stages are unchanged (remain Release).