Enable BinSkim build breaking in the official pipeline - #7722
Open
matouskozak wants to merge 1 commit into
Open
matouskozak wants to merge 1 commit into
matouskozak wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped configuration change has no unresolved review comments.
Pull request overview
Enables BinSkim build breaking in the official pipeline while preserving TSA, auto-baselining, and scan scope.
Changes:
- Sets
sdl.binskim.breaktotrue.
File summaries
| File | Description |
|---|---|
build/vsts-ci.yml |
Enables BinSkim policy failures to break the build. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7722 +/- ##
=======================================
Coverage 69.88% 69.88%
=======================================
Files 1487 1487
Lines 276249 276249
Branches 28291 28291
=======================================
+ Hits 193064 193069 +5
+ Misses 75696 75690 -6
- Partials 7489 7490 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set
sdl.binskim.break: trueinbuild/vsts-ci.ymlso the official pipeline explicitly requests build failure for BinSkim findings that meet the configured policy threshold. Keep TSA enabled and leave the scan scope unchanged.Note: this will not have the desired effect at the moment, not until we update the binskim baseline https://dev.azure.com/dnceng/internal/_build/results?buildId=3080307&view=results