Fix flaky parallel split query test: move ClearLog() before parallel tasks#38640
Merged
Conversation
…tasks Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
July 15, 2026 19:26
View session
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent flakiness in the parallel split-query tests by removing a race condition in SQL log clearing: ClearLog() was previously invoked inside concurrently running task bodies, allowing one task to clear the shared TestSqlLoggerFactory log after the other task had already started logging.
Changes:
- Move
ClearLog()to run once before starting parallel async tasks inCan_query_with_nav_collection_in_projection_with_split_query_in_parallel_async. - Apply the same change to the sync parallel variant
Can_query_with_nav_collection_in_projection_with_split_query_in_parallel_sync.
cincuranet
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can_query_with_nav_collection_in_projection_with_split_query_in_parallel_asyncintermittently failed withExpected: 400, Actual: 399becauseClearLog()was called inside each concurrent task. Task 2'sClearLog()could race and fire after Task 1 had already logged its first SQL statement, silently dropping it from the shared log.ClearLog()from inside each parallel task lambda to the outer test method, called once before tasks are launchedCan_query_with_nav_collection_in_projection_with_split_query_in_parallel_sync)