Fix test helper method override assertions for arbitrary parameters#38633
Open
JoasE wants to merge 3 commits into
Open
Fix test helper method override assertions for arbitrary parameters#38633JoasE wants to merge 3 commits into
JoasE wants to merge 3 commits into
Conversation
AndriySvyryd
approved these changes
Jul 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the AssertAllMethodsOverridden test helper to generate missing-override stubs for test methods with arbitrary parameters (instead of only supporting the legacy bool async pattern), improving the usefulness of the failure output across more test shapes.
Changes:
- Generate parameter and argument lists dynamically from reflected method parameters.
- Remove special-casing that previously skipped methods with parameters other than a single
bool async.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.