Open
Document breaking change: PhysicalFilesWatcher validates root and FileSystemWatcher paths#55776
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
3 tasks
…breaking change Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix PhysicalFilesWatcher to validate root and FileSystemWatcher paths
Document breaking change: PhysicalFilesWatcher validates root and FileSystemWatcher paths
Aug 28, 2026
gewarren
approved these changes
Aug 28, 2026
…idates-root-path.md
gewarren
marked this pull request as ready for review
August 28, 2026 21:50
gewarren
enabled auto-merge (squash)
August 28, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicalFilesWatcherconstructors now validate therootargument and its relationship to a suppliedFileSystemWatcher.Path, rejecting combinations at construction time that previously succeeded but generally didn't work correctly.New breaking-change article
docs/core/compatibility/extensions/11/physicalfileswatcher-validates-root-path.mdcovering:rootis now normalized viaPath.GetFullPath();nullthrowsArgumentNullException, invalid paths propagate thePath.GetFullPath()exception.FileSystemWatcher.Pathunrelated torootnow throwsArgumentException. It must be empty, equal toroot, or an ancestor/descendant of it.Index updates
toc.ymland11.mdunder the Extensions area.Example of the now-invalid pattern called out in the article:
Internal previews
Build report