Fix Update Libraries.cs - #55761
Conversation
The following errors have been fixed:
-Process.RunAndCaptureTextAsync – the parameter ["git", ["status", "--porcelain"]] was changed to new[] { "git", "status", "--porcelain" }, because the method signature expects a string array, not a nested array.
-ZLibEncoderSpanExample – using ZLibEncoder encoder = new(); was changed to using ZLibEncoder encoder = new ZLibEncoder();, since the parameterless constructor requires an explicit invocation.
-FloatingPointHexExample – added CultureInfo.InvariantCulture to ToString and Parse calls to ensure correct formatting and parsing of floating-point numbers in hexadecimal format.
-UtfValidationExample – "valid \uD83D\uDC4D end" was replaced with "valid \uD83D\uDC4D end".AsSpan() to properly convert the string to ReadOnlySpan<char>.
-TarArchiveFormatExample – the parameter format: in TarFile.CreateFromDirectory and CreateFromDirectoryAsync calls was corrected to entryFormat: to match the method signature.
-SafeFileHandlePipeExample – the asyncRead and asyncWrite parameters were removed from the CreateAnonymousPipe call, as this method does not accept these parameters.
-RandomGenericExample – maxValue: (byte)10 was simplified to maxValue: 10 (the type is inferred automatically).
MatveevichOne
left a comment
There was a problem hiding this comment.
The following errors have been fixed:
-Process.RunAndCaptureTextAsync – the parameter ["git", ["status", "--porcelain"]] was changed to new[] { "git", "status", "--porcelain" }, because the method signature expects a string array, not a nested array.
-ZLibEncoderSpanExample – using ZLibEncoder encoder = new(); was changed to using ZLibEncoder encoder = new ZLibEncoder();, since the parameterless constructor requires an explicit invocation.
-FloatingPointHexExample – added CultureInfo.InvariantCulture to ToString and Parse calls to ensure correct formatting and parsing of floating-point numbers in hexadecimal format.
-UtfValidationExample – "valid \uD83D\uDC4D end" was replaced with "valid \uD83D\uDC4D end".AsSpan() to properly convert the string to ReadOnlySpan.
-TarArchiveFormatExample – the parameter format: in TarFile.CreateFromDirectory and CreateFromDirectoryAsync calls was corrected to entryFormat: to match the method signature.
-SafeFileHandlePipeExample – the asyncRead and asyncWrite parameters were removed from the CreateAnonymousPipe call, as this method does not accept these parameters.
-RandomGenericExample – maxValue: (byte)10 was simplified to maxValue: 10 (the type is inferred automatically).
|
@MatveevichOne please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
The following errors have been fixed:
-Process.RunAndCaptureTextAsync – the parameter ["git", ["status", "--porcelain"]] was changed to new[] { "git", "status", "--porcelain" }, because the method signature expects a string array, not a nested array.
-ZLibEncoderSpanExample – using ZLibEncoder encoder = new(); was changed to using ZLibEncoder encoder = new ZLibEncoder();, since the parameterless constructor requires an explicit invocation.
-FloatingPointHexExample – added CultureInfo.InvariantCulture to ToString and Parse calls to ensure correct formatting and parsing of floating-point numbers in hexadecimal format.
-UtfValidationExample – "valid \uD83D\uDC4D end" was replaced with "valid \uD83D\uDC4D end".AsSpan() to properly convert the string to ReadOnlySpan.
-TarArchiveFormatExample – the parameter format: in TarFile.CreateFromDirectory and CreateFromDirectoryAsync calls was corrected to entryFormat: to match the method signature.
-SafeFileHandlePipeExample – the asyncRead and asyncWrite parameters were removed from the CreateAnonymousPipe call, as this method does not accept these parameters.
-RandomGenericExample – maxValue: (byte)10 was simplified to maxValue: 10 (the type is inferred automatically).
Internal previews
Build report