Repository navigation
Revert "[Diagnostics] Add EventPipe Buffer Mode and EventFilter" - #55195
Merged
Merged
Conversation
…)" This reverts commit df08d7d.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts recently added documentation for unreleased diagnostics features (EventPipe buffering mode and EventPipe provider event filters) across several diagnostics articles.
Changes:
- Reverts
EventPipeSessionConfigurationbuffering mode andEventPipeProviderevent filter API documentation. - Removes documentation for
DOTNET_EventPipeBufferingMode/streaming startup session behavior anddotnet-trace --buffering-mode. - Updates exception documentation structure in the NETCore client API article and rolls back several
ms.datevalues.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/core/diagnostics/microsoft-diagnostics-netcore-client.md | Reverts unreleased API surface docs (buffering mode, event filter) and adjusts exception docs and metadata. |
| docs/core/diagnostics/eventpipe.md | Reverts unreleased environment variable docs for non-lossy buffering/streaming and updates metadata. |
| docs/core/diagnostics/dotnet-trace.md | Reverts unreleased --buffering-mode option docs and updates metadata. |
| docs/core/diagnostics/dotnet-gcdump.md | Reverts non-lossy buffering note and updates troubleshooting wording and metadata. |
Comments suppressed due to low confidence (2)
docs/core/diagnostics/dotnet-gcdump.md:256
- Docs style in this repo uses "might" (not "may") for possibility. Update this sentence to match the style guidance.
`dotnet-gcdump` works by collecting a trace of events emitted by the garbage collector during an induced generation 2 collection. If the heap is sufficiently large, or there isn't enough memory to scale the eventing buffers, then the events required to reconstruct the heap graph from the trace may be dropped. In this case, to diagnose issues with the heap, it's recommended to collect a dump of the process.
docs/core/diagnostics/microsoft-diagnostics-netcore-client.md:593
- Docs style in this repo uses "might" (not "may") for possibility. Update this sentence to match the style guidance.
This may be thrown when the command is not supported by either the library or the target process's runtime.
gewarren
enabled auto-merge (squash)
July 30, 2026 19:06
wadepickett
approved these changes
Jul 30, 2026
wadepickett
left a comment
wadepickett
left a comment
Contributor
There was a problem hiding this comment.
@gewarren: Approved. A clean revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #54631 - just read comment that it hasn't released yet.
Internal previews