Produce better error messages in gcdump convert command#5814
Open
pavelsavara wants to merge 3 commits into
Open
Produce better error messages in gcdump convert command#5814pavelsavara wants to merge 3 commits into
pavelsavara wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Improves dotnet-gcdump convert failure handling by surfacing clearer error messages and guarding MemoryGraph.AllowReading() with exception handling.
Changes:
- Emit a user-facing error when
DumpFromEventPipeFilefails, with hints about likely causes. - Wrap
memoryGraph.AllowReading()in atry/catchto return a helpful message when the heap dump is incomplete.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
noahfalk
approved these changes
May 28, 2026
hoyosjs
approved these changes
May 30, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.