Skip to content

Improve API diff PR review workflow#10487

Merged
jeffhandley merged 6 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/api-diff-review-flow
Jul 23, 2026
Merged

Improve API diff PR review workflow#10487
jeffhandley merged 6 commits into
dotnet:mainfrom
jeffhandley:jeffhandley/api-diff-review-flow

Conversation

@jeffhandley

@jeffhandley jeffhandley commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary

  • Addresses the code-owner workflow question: the existing automation already marks an API diff PR Ready for Review when Preview 7 is locked and RC 1 bits are being produced. This adds a review checklist that tags repo and area owners using the live area-owners.md mapping.
  • Incorporates the related API-proposal request with best-effort proposal-to-diff matching, displayed in a collapsed details section.
  • Collapses the state-tracking block and fixes a concurrency case that could publish a blank PR body.

After merge, existing open API diff PRs will inherit this behavior during their next daily runs.

@jeffhandley
Upgrade to gh-aw v0.82.6
5dac208 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
Add API diff review checklist
23cdbd6 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
Add related API proposals
955fac4 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
Guard API diff PR bodies
3c6564e 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
Collapse API diff tracking state
b13a86f 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
jeffhandley requested a review from svick July 21, 2026 08:27
This was referenced Jul 21, 2026
Merged
Draft
svick
svick approved these changes Jul 21, 2026
View reviewed changes

@svick svick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of potential improvements.

Comment thread .github/workflows/api-diff-worker.md
Comment thread .github/workflows/api-diff-worker.md Outdated
@jeffhandley
Match API proposals through API reviews
565c996 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 47ddb766-0c8a-4b6f-952f-4d07a3bb20b3
@jeffhandley
jeffhandley requested a review from svick July 23, 2026 11:06
@jeffhandley
jeffhandley merged commit 2b9a764 into dotnet:main Jul 23, 2026
3 checks passed
@jeffhandley
jeffhandley deleted the jeffhandley/api-diff-review-flow branch July 23, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svick svick svick approved these changes

Assignees

No one assigned

Labels

agentic-workflows api-diff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeffhandley @svick