Fix missing indentation in generated API diffs#10472
Merged
Merged
Conversation
The api-diff tool had a bug where the first member of a type could lose its indentation in the generated markdown (dotnet#10213). This was caused by a synthesized default constructor lacking a body/semicolon, which fused it with the following member during formatting. The tool is being fixed in dotnet/sdk#54130, but the already-generated diff files need manual correction. This re-indents the 101 affected member lines across 19 files to align with their sibling members. Only whitespace (indentation) is changed; no API content is modified. Ref dotnet#10213 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jeffhandley
approved these changes
Jul 21, 2026
jeffhandley
left a comment
jeffhandley
left a comment
Member
There was a problem hiding this comment.
There are some corrections to nullability annotations on some of the APIs as well, but the updates match what's current so it's good with me to take those changes.
Member
Author
|
@jeffhandley This PR does not make any changes to nullability annotations. I have checked and Thanks for the review. |
Member
|
https://github.com/dotnet/core/pull/10472/changes#diff-3a7263794916137c3f544aa0b3986d611daa17c434f41cc26c751d2b6eab66c6 is what I saw, but could be I'm misinterpreting that diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The api-diff tool had a bug where the first member of a type could lose its indentation in the generated markdown (#10213). This was caused by a synthesized default constructor lacking a body/semicolon, which fused it with the following member during formatting.
The tool is being fixed in dotnet/sdk#54130, but the already-generated diff files need manual correction. This re-indents the 101 affected member lines across 19 files to align with their sibling members.
Only whitespace (indentation) is changed; no API content is modified.
Contributes to #10213