Skip to content

Enable nullable reference types in DetectIfAppWasUninstalled.cs #11599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Jun 8, 2026
+7 −6
Merged

Enable nullable reference types in DetectIfAppWasUninstalled.cs #11599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab00f12
Initial plan
Copilot Jun 8, 2026
a6ef075
Enable nullable reference types in DetectIfAppWasUninstalled.cs
Copilot Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/Xamarin.Android.Build.Debugging.Tasks/Tasks/DetectIfAppWasUninstalled.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
#nullable enable
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
Expand All @@ -14,15 +15,15 @@ public class DetectIfAppWasUninstalled : AndroidTask, ICancelableTask {
CancellationTokenSource tcs = new CancellationTokenSource ();
public override string TaskPrefix => "DIAWI";

public string AdbTarget { get; set; }
public string? AdbTarget { get; set; }

[Required]
public string PackageName { get; set; }
public string PackageName { get; set; } = "";

[Required]
public string UploadFlagFile { get; set; }
public string UploadFlagFile { get; set; } = "";

public string UserID { get; set; }
public string? UserID { get; set; }

public CancellationToken Token { get { return tcs.Token; } }
Comment on lines +26 to 28

Expand Down Expand Up @@ -57,7 +58,7 @@ public override bool RunTask()
}


async System.Threading.Tasks.Task<List<AndroidInstalledPackage>> QueryPackages (AndroidDevice device, string uploadFlagFileFullPath)
async System.Threading.Tasks.Task<List<AndroidInstalledPackage>?> QueryPackages (AndroidDevice device, string uploadFlagFileFullPath)
{
// DO NOT use the Log.XXXX methods in this method.
// Because this is running on a background thread they will
Expand Down