Skip to content

Bump Irony from 1.1.0 to 1.5.3#11561

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/release/10.0.1xx/Irony-1.5.3
Open

Bump Irony from 1.1.0 to 1.5.3#11561
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/nuget/release/10.0.1xx/Irony-1.5.3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jun 2, 2026

Updated Irony from 1.1.0 to 1.5.3.

Release notes

Sourced from Irony's releases.

1.2.0

What's new

  • #​51 Updated to NetStandard 2.0 — @​rivantsov
  • #​50 Better handling of newline characters — @​davidnemeti
  • #​48 NumberLiteral works properly when the decimal separator is not a dot — @​davidnemeti
  • #​46 Generate simpler parse tree for Kleene operator Q() — @​davidnemeti
  • #​36 Fix NullReferenceException when NodeCreator and DefaultNodeCreator are both null — @​maelmahdy
  • #​21 Set peverify-compat to ensure verifiable IL in C# 7.2 and up — @​dammejed

Nuget packages

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file. labels Jun 2, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file. .NET Pull requests that update .NET code labels Jun 2, 2026
@jonathanpeppers
Copy link
Copy Markdown
Member

@copilot investigate why we have this issue:

       "C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj" (Build;SignAndroidPackage target) (1:7) ->
       (_RunManagedAidlTool target) -> 
         C:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\36.1.73\tools\Xamarin.Android.Common.targets(1361,3): error XAGMA7028: System.IO.FileNotFoundException: Could not load file or assembly 'Irony, Version=1.5.3.0, Culture=neutral, PublicKeyToken=ca48ace7223ead47'. The system cannot find the file specified. [C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj]
       C:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\36.1.73\tools\Xamarin.Android.Common.targets(1361,3): error XAGMA7028: File name: 'Irony, Version=1.5.3.0, Culture=neutral, PublicKeyToken=ca48ace7223ead47' [C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj]
       C:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\36.1.73\tools\Xamarin.Android.Common.targets(1361,3): error XAGMA7028:    at Xamarin.Android.Tasks.GenerateManagedAidlProxies.RunTask() [C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj]
       C:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\36.1.73\tools\Xamarin.Android.Common.targets(1361,3): error XAGMA7028:    at Xamarin.Android.Tasks.GenerateManagedAidlProxies.RunTask() [C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj]
       C:\a\_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\36.1.73\tools\Xamarin.Android.Common.targets(1361,3): error XAGMA7028:    at Microsoft.Android.Build.Tasks.AndroidTask.Execute() [C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj]

    0 Warning(s)
    1 Error(s)

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 3, 2026

@copilot investigate why we have this issue:

       "C:\a\_work\1\a\TestRelease\06-02_23.06.35\temp\AidlTest.PrimitiveTypes\UnnamedProject.csproj" (Build;SignAndroidPackage targe...

Investigated. The root cause is an Irony version skew between this repo and the bundled Java.Interop submodule, because both ship a single Irony.dll into the same SDK tools directory.

What ships Irony.dll into the pack

  • This repo's src/Xamarin.Android.Build.Tasks and src/Xamarin.Android.Tools.Aidl both set OutputPath=$(MicrosoftAndroidSdkOutDir) and reference Irony — now 1.5.3 (Directory.Build.targets:8). GenerateManagedAidlProxies lives in Xamarin.Android.Build.Tasks.dll, which is therefore compiled against Irony, Version=1.5.3.0.
  • The Java.Interop submodule still pins Irony to 1.1.0 (external/Java.Interop/Directory.Build.targets:30). Its .NET tools (generator.csproj, Java.Interop.Tools.JavaSource.csproj, etc.) are built with OutputPath=$(UtilityOutputFullPath), and for the .NET ("CoreApps") tools that path is set to the same MicrosoftAndroidSdkOutDir via build-tools/scripts/Configuration.Java.Interop.Override.in.props:6 (UtilityOutputFullPathCoreApps=@MicrosoftAndroidSdkOutDir@). So they drop Irony.dll 1.1.0 into the identical folder.

Since Java.Interop is prepared before Xamarin.Android.sln (build-tools/scripts/DotNet.targets:26), the resulting tools/Irony.dll is non-deterministic across clean/incremental/release builds — and in the release build it did not satisfy the 1.5.3.0 reference baked into Xamarin.Android.Build.Tasks.dll, so the AIDL task failed to load it (XAGMA7028).

Fix: Irony must be bumped in lockstep. This dependabot PR only updated this repo; external/Java.Interop also needs Irony1.5.3 (a companion change in dotnet/java-interop on release/10.0.1xx, then a submodule bump here). I can't update the submodule pointer from this PR, so it shouldn't be merged on its own until Java.Interop is updated to match.

@jonathanpeppers jonathanpeppers force-pushed the dependabot/nuget/release/10.0.1xx/Irony-1.5.3 branch from 864fb52 to f14bdb4 Compare June 3, 2026 16:29
@jonathanpeppers jonathanpeppers changed the base branch from release/10.0.1xx to main June 3, 2026 16:29
---
updated-dependencies:
- dependency-name: Irony
  dependency-version: 1.5.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@jonathanpeppers jonathanpeppers force-pushed the dependabot/nuget/release/10.0.1xx/Irony-1.5.3 branch from f14bdb4 to 29fbf9b Compare June 3, 2026 16:30
@jonathanpeppers
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants