Guard Mono-specific AOT targets for CoreCLR runtime, add XA1042 warning#11070
Open
Guard Mono-specific AOT targets for CoreCLR runtime, add XA1042 warning#11070
Conversation
…r Mono-specific properties used with non-MonoVM runtimes Agent-Logs-Url: https://github.com/dotnet/android/sessions/a5ac81b3-0cd5-4a8a-9394-531fa1466274 Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Mono targets execution when using CoreCLR runtime
Guard Mono-specific AOT targets for CoreCLR runtime, add XA1042 warning
Apr 2, 2026
Member
|
@copilot we need to fix this test: When We may want to add an additional test so this is clearer. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents Mono AOT build logic from running when a project is configured for non-Mono runtimes (CoreCLR/NativeAOT), and adds a dedicated warning (XA1042) to guide users who have Mono-only AOT properties set unconditionally (e.g., via Directory.Build.props).
Changes:
- Guard MonoAOTCompiler SDK imports and
_AndroidAotexecution so they only run forMonoVM. - Detect
RunAOTCompilation/EnableLLVMset under non-Mono runtimes, reset them tofalse, and emit XA1042 with actionable guidance. - Add XA1042 resource + documentation and add tests validating warning emission and successful builds under CoreCLR.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.Aot.targets | Restricts MonoAOTCompiler SDK imports and _AndroidAot target to MonoVM runtime only. |
| src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets | Detects Mono-only properties under non-Mono runtimes, sets XA1042 flags, and resets the properties to false. |
| src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets | Emits XA1042 warnings when the corresponding flags are set. |
| src/Xamarin.Android.Build.Tasks/Properties/Resources.resx | Adds localized XA1042 warning message template. |
| src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs | Regenerates strongly-typed resource accessor for XA1042. |
| Documentation/docs-mobile/messages/xa1042.md | Adds end-user documentation and migration guidance for XA1042. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AotTests.cs | Adds tests ensuring CoreCLR builds succeed and XA1042 is emitted when Mono-only properties are set. |
Files not reviewed (1)
- src/Xamarin.Android.Build.Tasks/Properties/Resources.Designer.cs: Language not supported
…ated test Agent-Logs-Url: https://github.com/dotnet/android/sessions/1e564b95-24aa-400d-b01f-f153bea868fd Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Contributor
Author
... Fixed in b2456ac. The issue was that my XA1042 change resets Two changes:
|
The CalculateProjectDependencies task was emitting 'ndk-bundle' as the
AndroidDependency item identity, but modern Android SDK uses side-by-side
NDK installed under 'ndk/{version}'. The GoogleV2 manifest doesn't have
a component with path 'ndk-bundle', causing InstallAndroidDependencies
to fail with 'could not be resolved' warnings.
Change the identity to 'ndk' so it matches the GoogleV2 manifest component
and resolves correctly.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use ndk/{version} (e.g. ndk/27.2.1247901) as the AndroidDependency
identity, matching the pattern used by build-tools/{version} and
cmdline-tools/{version}. This allows the GoogleV2 manifest to resolve
the NDK component correctly.
Also fix tests:
- Skip GetDependencyNdkRequiredConditions for NativeAOT when
ndkRequired=false, since NativeAOT always requires NDK via
PublishAot=true
- Update NativeAotRequiresNdk assertion from ndk-bundle to ndk/
- Use ndk/ prefix matching in StringAssertEx to avoid false positives
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The downstream InstallAndroidDependencies task (from android-platform-support)
joins the identity and version with a semicolon separator to form the SDK
manager path (e.g. ndk;27.2.12479018). Using ndk/{version} as the identity
caused a malformed path like 'ndk;27.2.12479018/27.2.12479018' that couldn't
be resolved.
The correct identity is just 'ndk' with the version in metadata, which
produces the expected 'ndk;27.2.12479018' component path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The bundled Xamarin manifest uses 'ndk-bundle' as the component path, while the GoogleV2 manifest (once regenerated) will use 'ndk'. Emit both identities so the dependency resolves regardless of which manifest the downstream InstallAndroidDependencies task is configured to use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The bundled manifests in android-platform-support still use ndk-bundle as the component path. Revert to the original identity and only add the NativeAOT-specific test changes: - Skip GetDependencyNdkRequiredConditions for NativeAOT when ndkRequired=false (PublishAot=true always requires NDK) - Add NativeAotRequiresNdk test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The GoogleV2 manifest from Google does not have an ndk-bundle component, so the NDK dependency cannot be resolved for runtimes that require it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
<RunAOTCompilation>true</RunAOTCompilation>in a project file (e.g.Directory.Build.props) causes build failures when switching from Mono to CoreCLR, becauseMonoAOTCompilerruns unconditionally regardless of the active runtime.Changes
Microsoft.Android.Sdk.Aot.targets— Add'$(_AndroidRuntime)' == 'MonoVM'guard to theImportGroup(MonoAOTCompiler SDK imports) and_AndroidAottarget conditionMicrosoft.Android.Sdk.DefaultProperties.targets— AfterRunAOTCompilationdefaults are resolved, detect Mono-specific properties (RunAOTCompilation,EnableLLVM) set with non-MonoVM runtimes, reset them tofalse, and set flags for warning emissionXamarin.Android.Common.targets— Emit new XA1042 warning when the flags are set; add$(PublishAot)condition to_NdkRequiredso NativeAOT always requires the Android NDKResources.resx/Resources.Designer.cs— New XA1042 messagexa1042.md— Documentation for the new warningAotTests.cs— Two tests:RunAOTCompilationWithCoreClrWarnsAndSkipsMonoAotandEnableLLVMWithCoreClrWarnsAndIsIgnoredAndroidDependenciesTests.cs— NewNativeAotRequiresNdktest validating that NativeAOT always lists the NDK as a dependencyExample warning
Migration guidance