Enable release package completion triggers - #4694
paulmedynski wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused YAML updates correctly implement the stated completion-trigger behavior.
Pull request overview
Enables Kerberos and Managed Instance pipelines to detect package completions from all supported internal release branches.
Changes:
- Adds release/7.1, 7.0, and 6.1 branch filters.
- Documents Azure’s default-branch trigger evaluation behavior.
File summaries
| File | Description |
|---|---|
eng/pipelines/ci/managed-instance/sqlclient-ci-managed-instance-pipeline.yml |
Expands completion-trigger branches. |
eng/pipelines/ci/kerberos/sqlclient-ci-kerberos-pipeline.yml |
Expands completion-trigger branches. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulmedynski
added
the
Area\Engineering
| # configured default branch. Include release branches that contain this pipeline; | ||
| # after a match, Azure runs it using the triggering package run's branch and commit. | ||
| - release/7.1 | ||
| - internal/release/7.1 |
There was a problem hiding this comment.
Does stress pipeline not support older versions?
There was a problem hiding this comment.
Yes, but on those branches it runs via other triggers. For 7.1 it was migrated to a resource-completion trigger like Kerberos and MI. I will tidy up the Kerberos and MI resource triggers as well, and ensure the comment explains the intent.
There was a problem hiding this comment.
🟡 Changes recommended
Kerberos and Managed Instance omit the 7.0 and 6.1 branches required by the PR description.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
Description
Update the pipeline-completion filters on
mainso Azure can discover eligible package-pipeline completions for supported release branches:internal/main,internal/release/7.1,internal/release/7.0, andinternal/release/6.1.main,internal/main,release/7.1, andinternal/release/7.1. The Stress pipeline does not exist on the 7.0 or 6.1 branches.Azure evaluates pipeline-completion filters from each downstream pipeline's Default branch for manual and scheduled builds. Listing the supported release branches on
mainallows Azure to discover eligible package-pipeline completions; because the upstream and downstream pipelines share a repository, the downstream run still uses the triggering package run's branch and commit.Both Stress pipeline registrations are currently disabled. Adding their 7.1 discovery filters now allows them to work immediately when re-enabled.
Release-branch YAML remains scoped to its own release branch, so this change does not need to be backported.
There are no public API or product behavior changes.