Normalize TDS UDT and XML metadata types

[benrr101]

Description

Applies the normalized TDS metadata model to user-defined type and XML schema metadata.

• Renames SqlMetaDataUdt and SqlMetaDataXmlSchemaCollection to TdsUdtTypeInfo and TdsXmlTypeInfo.
• Converts eligible fields to documented properties.
• Replaces the bespoke CopyFrom pattern with conventional clone methods and copy constructors across UDT, XML, column, and general type metadata.
• Updates parser, connection, reader, parameter, and column call sites.
• Adds focused unit coverage for cloning the affected metadata types.

This is layer 3 of 3 in the TDS parser organization stack. It targets dev/russellben/tokens/tdstypeinfo, so review should focus on UDT/XML metadata and clone semantics.

Issues

No linked issue; this is an internal naming and maintainability refactor.

Testing

Adds focused unit tests for TdsTypeInfo, TdsUdtTypeInfo, and TdsXmlTypeInfo clone behavior. CI will run the complete dependent branch across the supported target frameworks.

Guidelines

• Contributing
• Code of Conduct
• Best Practices
• Coding Style
• Review Process

[Copilot]

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The UDT Type annotation no longer preserves the trimming contract through property accessors.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 6
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The UDT Type property loses its trimming data-flow contract, and the new tests omit required XML documentation.

Review details

Suppressed comments (5)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Parser/Tokens/TdsUdtTypeInfo.cs:45

• Apply DynamicallyAccessedMembers to the property, not only its compiler-generated backing field. The getter currently exposes an unannotated Type, so calls such as SerializationHelperSql9.Deserialize lose the trimming contract and may emit linker warnings or allow required UDT members to be removed.

    [field: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)]

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:9

• The repository's testing guide requires behavior-focused XML summaries on every test class and every test method (.github/instructions/testing.instructions.md:176-192). Add summaries for this class and both [Fact] methods.

public class TdsXmlTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsUdtTypeInfoTests.cs:10

• The repository's testing guide requires behavior-focused XML summaries on every test class and every test method (.github/instructions/testing.instructions.md:176-192). Add summaries for this class and all three [Fact] methods.

public class TdsUdtTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsTypeInfoTests.cs:11

• The repository's testing guide requires behavior-focused XML summaries on every test class and every test method (.github/instructions/testing.instructions.md:176-192). Add summaries for this class and all three [Fact] methods.

public class TdsTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:15

• This variable holds XML type information, so the UDT-oriented name is misleading in this test.

        var udtTypeInfo = new TdsXmlTypeInfo();

• Files reviewed: 15/15 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

The trimming annotation and hidden clone method introduce correctness risks, while the new tests also violate repository documentation requirements.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (5)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Parser/Tokens/TdsUdtTypeInfo.cs:47

• The [field:] target annotates only the generated backing field, so the generated property getter does not expose a Type carrying the required member guarantees. Call sites that pass Type to the UDT serializers can therefore trigger trimming diagnostics or lose the intended preservation. Apply the annotation to the property itself, preserving the semantics of the former annotated field.

    [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)]
    #endif
    internal Type Type { get; set; }

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:9

• This new test class and its [Fact] methods lack the required behavior-focused XML summaries. .github/instructions/testing.instructions.md:181-190 requires summaries at both class and test-method level; please document each declaration.

public class TdsXmlTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsUdtTypeInfoTests.cs:10

• This new test class and its [Fact] methods lack the required behavior-focused XML summaries. .github/instructions/testing.instructions.md:181-190 requires summaries at both class and test-method level; please document each declaration.

public class TdsUdtTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsTypeInfoTests.cs:11

• This new test class and its [Fact] methods lack the required behavior-focused XML summaries. .github/instructions/testing.instructions.md:181-190 requires summaries at both class and test-method level; please document each declaration.

public class TdsTypeInfoTests

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:15

• This XML metadata test names the subject udtTypeInfo, which makes the assertions appear to cover the wrong metadata kind. Rename it to xmlTypeInfo so the test's intent is unambiguous.

        var udtTypeInfo = new TdsXmlTypeInfo();

• Files reviewed: 15/15 changed files
• Comments generated: 3
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

The new tests violate the repository’s mandatory XML documentation convention, and one XML test uses misleading UDT terminology.

Review details

Suppressed comments (4)

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:12

• This new test class and its [Fact] methods omit the behavior-focused XML summaries required by .github/instructions/testing.instructions.md:181-192. Please document the class and each test method, including why the clone/default-value behavior matters.

public class TdsXmlTypeInfoTests
{
    [Fact]
    public void Constructor_InitializesPropertiesWithDefaultValues()

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsTypeInfoTests.cs:14

• This new test class and its [Fact] methods omit the behavior-focused XML summaries required by .github/instructions/testing.instructions.md:181-192. Please document the class and each test method, including why each clone scenario matters.

public class TdsTypeInfoTests
{
    [Fact]
    public void Clone_CopiesAllUnclonedProperties()

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsXmlTypeInfoTests.cs:15

• This variable contains TdsXmlTypeInfo, so the UDT-oriented name is misleading in an XML metadata test. Rename it to xmlTypeInfo to keep the test terminology aligned with the type under test.

        var udtTypeInfo = new TdsXmlTypeInfo();

src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/Parser/Tokens/TdsUdtTypeInfoTests.cs:13

• This new test class and its [Fact] methods omit the behavior-focused XML summaries required by .github/instructions/testing.instructions.md:181-192. Please document the class and each test method, including why the clone/default-value behavior matters.

public class TdsUdtTypeInfoTests
{
    [Fact]
    public void Constructor_InitializesPropertiesWithDefaultValues()

• Files reviewed: 15/15 changed files
• Comments generated: 0 new
• Review effort level: Balanced