Remove RID-specific SqlClient DLLs - #4673
Open
edwardneal wants to merge 1 commit into
Open
edwardneal wants to merge 1 commit into
edwardneal wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I'm removing the now-vestigial
runtimes/[rid]/lib/[tfm]package paths. The binaries are always identical, so having one copy per RID no longer adds any value. A follow-up PR will deal with thenotsupportedproject - that's probably going to be much larger, and I don't want the user-facing impact to get lost. Since that project is going to be removed anyway, I've also left its unnecessary TFM targets in situ.I'm pushing this fix early to make sure it lands in 8.0.0 preview 1 and gets as much testing exposure as possible.
One other change appears in this: note that the XML documentation for net462 now comes from the ref project, rather than from the implementation project. This is deliberate, and it ensures that we no longer ship XML documentation for internal types. Note that
lib/net462/Microsoft.Data.SqlClient.xmlin v7.0.2 currently includes these and doing so makes net462 consistent with net8.0 and net9.0.Issues
Contributes to #4239.
Fixes #903.
Fixes #3006.
Fixes #3577.
Testing
Unit tests run locally. I can reference the output nupkg via a netfx project which still uses packages.config, and by loading the DLL in
lib/net462in PowerShell.