chore: Fix error when running benchmark with file-based app#3198
Merged
timcassell merged 2 commits intoJul 23, 2026
Conversation
Collaborator
We should rather catch the exception like we do in other parts of the code that use COM. Built-in COM can be disabled without AOT, and I believe it can be enabled with AOT. |
timcassell
reviewed
Jul 18, 2026
timcassell
reviewed
Jul 18, 2026
timcassell
requested changes
Jul 18, 2026
filzrev
force-pushed
the
chore-fix-error-on-file-based-app
branch
from
July 23, 2026 04:30
a5d872c to
2cfc0c7
Compare
Contributor
Author
I've updated code based on following try-catch code. BenchmarkDotNet/src/BenchmarkDotNet/Helpers/TaskbarProgress.cs Lines 125 to 130 in 2365829 |
filzrev
force-pushed
the
chore-fix-error-on-file-based-app
branch
from
July 23, 2026 04:42
2cfc0c7 to
49bcf23
Compare
timcassell
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended following validation error when running benchmark with file-based apps.
What's changed in this PR
1.
Portability/RuntimeInformation.csAdd
IsFileBasedAppAPI to detect benchmark is running on File-based apps or not.2.
ShadowCopyValidator.csAdd logics to skip validatation when running file-based apps.
3.
MosCpuDetector.csAdd logics to avoid following errors when running file-based apps without
PublishAot=falsesetting.(Note: As far as I knows, Currently Benchmark Host is not support NativeAot, Because it use reflections)
TestCode