Dynamically set the culture updates - #37530
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ASP.NET Core documentation to use Minimal APIs for culture-selection redirect endpoints (where applicable) and to explicitly cover Minimal API usage of LocalRedirect for open-redirect protection.
Changes:
- Replaced controller-based culture-setting guidance with a Minimal API endpoint for
>= aspnetcore-6.0in the Blazor globalization/localization article, with monikered guidance by hosting model/version. - Added Minimal API coverage for
LocalRedirectto the open redirect prevention article, alongside existing MVC guidance. - Updated front matter metadata (
ai-usage) and refreshedms.datein touched articles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| aspnetcore/blazor/globalization-localization.md | Updates culture-selection guidance and code to use a Minimal API redirect endpoint and refreshes version-specific instructions. |
| aspnetcore/security/preventing-open-redirects.md | Adds Minimal API example for LocalRedirect and updates metadata/date. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
@guardrex: Approved. I couldn't find any new issues beyond what was already addressed. Looks great.
|
Ooops! There's a small merge conflict to resolve. I'll fix it as soon as I get back to the office. |
|
@wadepickett ... Ok, that licks the merge conflict. 👍 |
wadepickett
left a comment
wadepickett
left a comment
There was a problem hiding this comment.
@guardrex: Re-approved.
Fixes #37216
The main focus coming in was to convert the controller portions over to Minimal APIs for >=.NET 6 coverage. I also discovered several additional improvements while working on these sections.
I also noticed in passing that the Prevent open redirect attacks in ASP.NET Core article didn't mention Minimal APIs for
LocalRedirect, so I added that in passing. I've added the article to the list of articles that need a bit more Blazor/Minimal API work on #34356. I'll address it later. 🏃♂️Internal previews