Fix OSGi resolution, YAML load, and stale per-host cache on recent dotCMS#1
Open
fmontes wants to merge 1 commit into
Open
Fix OSGi resolution, YAML load, and stale per-host cache on recent dotCMS#1fmontes wants to merge 1 commit into
fmontes wants to merge 1 commit into
Conversation
…tCMS - Drop imports for non-exported packages (com.dotcms.api.system.event.message, common.Assert, javax.annotation.Nonnull) - Loosen Import-Package version ranges and disable uses: directive in bundle plugin - Load Dotuserproxy.yml via Bundle.getEntry instead of getResourceAsStream - Remove per-host lazyUserProxyMap; rely on dotCMS AppsCache to avoid stale config after save Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On recent dotCMS the plugin failed to deploy with cascading OSGi resolution errors, then with an empty
Dotuserproxy.yml, then with stale per-host config after saves. Observed logs:Unable to resolve ... osgi.wiring.package=com.dotcms.api.system.event.messageUnable to resolve ... osgi.wiring.package=commonjavax.annotation [3.0.0, 4.0.0)andcommons-io [1.4.0, 2.0.0)unresolvedAppsAPIImpl: Error reading yml file ... No content to map due to end-of-inputFixes: dropped imports of non-exported packages (replaced with logger / inline checks), loosened
Import-Packageversions and disableduses:so the bundle tolerates dotCMS library upgrades, switched toBundle.getEntryfor the YAML so resources at the JAR root resolve under the OSGi classloader, and removed the per-hostlazyUserProxyMapso saved config is picked up on the next request instead of requiring a bundle restart.Test plan
./mvnw clean packagebuilds the bundleDotuserproxy.ymllands at full size; App appears in Apps UI🤖 Generated with Claude Code