fix(pg-base): bump backup-image pg_dump to client 18, add --no-install-recommends - #36812
Open
sfreudenthaler wants to merge 1 commit into
Open
fix(pg-base): bump backup-image pg_dump to client 18, add --no-install-recommends#36812sfreudenthaler wants to merge 1 commit into
sfreudenthaler wants to merge 1 commit into
Conversation
…6811) pg_dump refuses servers newer than its own major; prod RDS is 15.x today (client-16 works only coincidentally) while the rest of the repo is on PG18 — client-18 dumps everything ≤18 and survives prod upgrades. Also applies the repo-standard --no-install-recommends (last stray, same exposure class as #36806). Closes: #36811 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ogYXVeZsBVUHkwzdStYPJ
Contributor
|
Claude finished @sfreudenthaler's task in 26s —— View job PR Review: bump pg_dump to client 18
New IssuesNo issues found. The change is a clean two-part edit on
Points worth noting (non-blocking):
LGTM — approve. (Note: I can't submit a formal GitHub approval for security reasons; this is review feedback only.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pg-base image exists to carry
pg_dumpfor backup jobs.pg_dumpcan dump servers ≤ its own major and refuses newer — prod RDS is PG 15.15–15.17 today (verified across us-east-1/ca-central-1/eu-central-1/ap-southeast-2), so the current client-16 works only coincidentally; the repo fleet is already on PG18 and prod will follow. Client-18 handles all of it. Also applies the repo-standard--no-install-recommendsto this last stray install (same class as #36806).Verified: the exact new install line runs clean on ubuntu:24.04 and
pg_dump --versionreports 18.x (the image's own build-time self-check).Closes: #36811
🤖 Generated with Claude Code
https://claude.ai/code/session_012ogYXVeZsBVUHkwzdStYPJ