feat(a11y): Accessibility Studio portlet + AI agent platform (@dotcms/ai, MCP server, agent UI) #36641
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| .env | ||
|
|
||
| vite.config.*.timestamp* | ||
| vitest.config.*.timestamp* | ||
|
|
||
| .angular |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| import { includeMatcher, splitIncludePatterns } from './assets-transfer'; | ||
|
Member
There was a problem hiding this comment. This spec covers Would it be worth adding a few tests around those paths, given they're the behavior changes the rework is for? |
||
|
|
||
| describe('splitIncludePatterns', () => { | ||
| it('splits comma-separated patterns and trims them', () => { | ||
| expect(splitIncludePatterns('*.vtl, *.scss')).toEqual(['*.vtl', '*.scss']); | ||
| }); | ||
|
|
||
| it('does NOT split on a comma inside a brace group', () => { | ||
| expect(splitIncludePatterns('*.{png,webp,jpg}')).toEqual(['*.{png,webp,jpg}']); | ||
| }); | ||
|
|
||
| it('splits around a brace group but keeps the group intact', () => { | ||
| expect(splitIncludePatterns('*.{png,jpg},*.vtl')).toEqual(['*.{png,jpg}', '*.vtl']); | ||
| }); | ||
|
|
||
| it('drops empty entries and returns [] for undefined', () => { | ||
| expect(splitIncludePatterns('*.png,,')).toEqual(['*.png']); | ||
| expect(splitIncludePatterns(undefined)).toEqual([]); | ||
| }); | ||
| }); | ||
|
|
||
| describe('includeMatcher', () => { | ||
| it('matches everything when no include is given', () => { | ||
| const m = includeMatcher(); | ||
| expect(m('a.png')).toBe(true); | ||
| expect(m('deep/nested/a.vtl')).toBe(true); | ||
| }); | ||
|
|
||
| // The three repro cases from the bug report — files live directly in the source dir. | ||
| describe('bug report repro (top-level files)', () => { | ||
| it('brace expansion matches top-level files (was: 0 matched)', () => { | ||
| const m = includeMatcher('*.{png,webp,jpg}'); | ||
| expect(m('amazon-logo.png')).toBe(true); | ||
| expect(m('book1.webp')).toBe(true); | ||
| expect(m('cover.jpg')).toBe(true); | ||
| expect(m('notes.txt')).toBe(false); | ||
| }); | ||
|
|
||
| it('** globstar matches a top-level file too (was: 0 matched)', () => { | ||
| const m = includeMatcher('**/*.png'); | ||
| expect(m('amazon-logo.png')).toBe(true); // no subdirectory — must still match | ||
| expect(m('img/hero.png')).toBe(true); | ||
| expect(m('a/b/c/deep.png')).toBe(true); | ||
| expect(m('a/b/c/deep.webp')).toBe(false); | ||
| }); | ||
|
|
||
| it('plain top-level glob still works', () => { | ||
| const m = includeMatcher('*.png'); | ||
| expect(m('amazon-logo.png')).toBe(true); | ||
| expect(m('book1.webp')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('single-star does not cross directories', () => { | ||
| it('"*.png" (no slash) matches a basename anywhere in the tree', () => { | ||
| const m = includeMatcher('*.png'); | ||
| expect(m('a.png')).toBe(true); | ||
| expect(m('deep/dir/a.png')).toBe(true); // basename match, unanchored | ||
| }); | ||
|
|
||
| it('an anchored "img/*.png" only matches that one directory level', () => { | ||
| const m = includeMatcher('img/*.png'); | ||
| expect(m('img/a.png')).toBe(true); | ||
| expect(m('img/sub/a.png')).toBe(false); // * does not cross / | ||
| expect(m('other/a.png')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('** globstar depth', () => { | ||
| it('"img/**/*.png" matches zero or more intermediate dirs', () => { | ||
| const m = includeMatcher('img/**/*.png'); | ||
| expect(m('img/a.png')).toBe(true); // zero intermediate dirs | ||
| expect(m('img/sub/a.png')).toBe(true); | ||
| expect(m('img/a/b/c.png')).toBe(true); | ||
| expect(m('other/a.png')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('? single char', () => { | ||
| it('matches exactly one non-slash char', () => { | ||
| const m = includeMatcher('file?.txt'); | ||
| expect(m('file1.txt')).toBe(true); | ||
| expect(m('fileA.txt')).toBe(true); | ||
| expect(m('file.txt')).toBe(false); | ||
| expect(m('file12.txt')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('literals are escaped', () => { | ||
| it('a dot in the pattern is literal, not "any char"', () => { | ||
| const m = includeMatcher('*.png'); | ||
| expect(m('axpng')).toBe(false); // the "." must be a real dot | ||
| expect(m('a.png')).toBe(true); | ||
| }); | ||
|
|
||
| it('multiple patterns OR together', () => { | ||
| const m = includeMatcher('*.vtl,*.scss'); | ||
| expect(m('theme.vtl')).toBe(true); | ||
| expect(m('styles.scss')).toBe(true); | ||
| expect(m('image.png')).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| it('is case-insensitive', () => { | ||
| const m = includeMatcher('*.PNG'); | ||
| expect(m('photo.png')).toBe(true); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.