Skip to content

[auto-bump] [no-release-notes] dependency by reltuk#2912

Closed
coffeegoddd wants to merge 1 commit into
mainfrom
reltuk-c6a7ab6d
Closed

[auto-bump] [no-release-notes] dependency by reltuk#2912
coffeegoddd wants to merge 1 commit into
mainfrom
reltuk-c6a7ab6d

Conversation

@coffeegoddd

Copy link
Copy Markdown
Contributor

An Automated Dependency Version Bump PR 👑

Initial Changes

The changes contained in this PR were produced by `go get`ing the dependency.

```bash
go get github.com/dolthub/[dependency]/go@[commit]
```

@github-actions

Copy link
Copy Markdown
Contributor
Main PR
covering_index_scan_postgres 1841.99/s 1880.05/s +2.0%
groupby_scan_postgres 134.29/s 137.48/s +2.3%
index_join_postgres 655.39/s 660.51/s +0.7%
index_join_scan_postgres 802.18/s 807.28/s +0.6%
index_scan_postgres 26.92/s 26.65/s -1.1%
oltp_delete_insert_postgres 765.30/s 787.40/s +2.8%
oltp_insert 661.49/s 658.89/s -0.4%
oltp_point_select 2954.48/s 2957.06/s 0.0%
oltp_read_only 3011.11/s 3005.62/s -0.2%
oltp_read_write 2155.72/s 2300.67/s +6.7%
oltp_update_index 702.94/s 684.51/s -2.7%
oltp_update_non_index 726.82/s 671.30/s -7.7%
oltp_write_only 1701.65/s 1699.55/s -0.2%
select_random_points 1930.83/s 1924.65/s -0.4%
select_random_ranges 1556.81/s 1524.51/s -2.1%
table_scan_postgres 24.94/s 24.92/s -0.1%
types_delete_insert_postgres 750.93/s 707.96/s -5.8%
types_table_scan_postgres 11.15/s 11.07/s -0.8%

@itoqa

itoqa Bot commented Jul 10, 2026

Copy link
Copy Markdown

Ito QA test results
Commit: 33e9fa5: 5 test cases ran, 4 passed ✅, 1 additional finding ⚠️.

Summary

This run covers core database behavior across startup and authentication, routine SQL schema/data operations, and replication startup under both normal and edge-case configuration inputs. Overall behavior looks stable for the changes in this PR, with expected functionality working in the main product paths that were exercised.

Safe to merge — there are no failures attributable to this PR, with no regressions, no new PR-caused failures, and no previously flagged PR failures still failing. A medium-severity replication configuration issue remains in the suite, but it is pre-existing and not caused by this change, so it is a flag-for-later rather than a merge blocker for this PR.

Tests run by Ito

View full run

Result Severity Type Description
Bootstrap Doltgres default startup behavior works as expected: with no user/password overrides it listens on localhost:5432, accepts postgres/password, supports normal SQL operations, and rejects incorrect credentials.
Engine ALTER SEQUENCE ... OWNED BY completed successfully, and ownership resolution via pg_get_serial_sequence returned public.customer_orders_id_seq for both schema-qualified and search_path-based table lookups.
Replication Reclassified from blocked to passed: the harness terminated after batch completion, but captured evidence confirms replication startup succeeded and the SQL endpoint stayed responsive under valid postgres_replication settings.
Storage ALTER TABLE RENAME preserved all inserted rows under the new table name, and the old table name was no longer accessible.
⚠️ Medium severity Replication The primary replication DSN is assembled from raw user and password strings, so reserved characters are interpreted as URL syntax and the resulting DSN cannot be parsed correctly.
Additional Findings Details

These findings are unrelated to the current changes but were observed during testing.

🟡 Replication DSN assembly handles reserved credential characters safely
  • Severity: Medium Medium severity
  • Description: The primary replication DSN is assembled from raw user and password strings, so reserved characters are interpreted as URL syntax and the resulting DSN cannot be parsed correctly.
  • Impact: Users may encounter replication operations that stall and do not complete without retrying.
  • Steps to Reproduce:
    1. Configure postgres_replication with a valid primary endpoint and credentials where the password includes reserved URI characters such as @, :, /, #, or ?.
    2. Start the server so startReplication builds the primary DSN and launches the replicator.
    3. Observe replication logs showing URL parse failures and retried startup instead of a valid replication connection.
  • Stub / mock content: No stubs, mocks, or bypasses were applied for this test in the recorded run.
  • Code Analysis: In startReplication, primaryDns is created with fmt.Sprintf("postgres://%s:%s@%s:%d/%s", ...) using raw PostgresUser and PostgresPassword values. Because credentials are not URL-escaped before interpolation, reserved characters in the password alter URL grammar and cause parse errors (for example invalid port fragments) before a connection to the intended host/port can be established. The smallest practical fix is to construct the DSN with net/url components (or safely escaped userinfo) so credentials are encoded and the endpoint semantics are preserved.
Evidence Package

Tip

Reply with @itoqa to send us feedback on this test run.

@github-actions

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 18274 18275
Failures 23816 23815
Partial Successes1 5335 5335
Main PR
Successful 43.4165% 43.4189%
Failures 56.5835% 56.5811%

${\color{lightgreen}Progressions (1)}$

random

QUERY: (SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1);

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been superseded by #2915

@github-actions github-actions Bot closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants