ItemStar: Implement and mark as matching - #81
Open
bemug wants to merge 2 commits into
Open
Conversation
SwareJonge
reviewed
Aug 24, 2026
Collaborator
|
It seems like you forgot to implement But all in all, nice job and thanks for your contribution! |
Author
|
Thank you. |
joakim-d
reviewed
Aug 25, 2026
Report for MarioClub_us (dbdda50 - 332ef2c)📈 Matched code: 46.94% (+0.05%, +1580 bytes) ✅ 18 new matches
📈 4 improvements in unmatched items
|
Collaborator
|
Also needs to be rebased since it picks up stuff from my JAudio commits somehow |
Author
|
Should be ok now. |
Switch mRotMtx type from Mtx to JGeometry::TRot3f so we can call set() directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR to this project, thanks everyone for the help to get me this far.