fix(router): standardize link and resource path resolution - #2793
Open
sy-records wants to merge 1 commit into
Open
fix(router): standardize link and resource path resolution#2793sy-records wants to merge 1 commit into
sy-records wants to merge 1 commit into
Conversation
- resolve relative paths from the current Markdown page - resolve absolute paths from the domain root - add configurable and per-element base path overrides - prevent duplicate base paths and preserve sidebar activation - add regression tests and configuration documentation Fixes #1891
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize path handling for links, images, and embedded resources.
This change:
relativeBasePathandabsoluteBasePathconfiguration options.:basepathMarkdown attribute.basePathsources.No UI changes are introduced, so before/after screenshots are not applicable.
Related issue, if any:
Fixes #1891
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Relative links are now resolved from the current Markdown page by default because
relativePathdefaults totrue. Applications that depend on the previous index-relative behavior can restore it with:Absolute paths now resolve from the domain root. Sites that want absolute paths rooted at the Docsify site directory can configure
absoluteBasePath.The default
basePathvalue is nownullinstead of an empty string.Tested in the following browsers: