Skip to content

feat: improve indexing and embedded search#2734

Open
sy-records wants to merge 3 commits into
docsifyjs:developfrom
sy-records:fix/2674
Open

feat: improve indexing and embedded search#2734
sy-records wants to merge 3 commits into
docsifyjs:developfrom
sy-records:fix/2674

Conversation

@sy-records
Copy link
Copy Markdown
Member

@sy-records sy-records commented May 25, 2026 •
edited
Loading

Summary

  • Fix Search indexing does not work if some links are broken
  • Allow full text search on embedded content

Related issue, if any:

Close #2674
Close #2689, Thanks @Bowl42
Close #2675, Thanks @kokovtsev
Close #1277

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

@sy-records is attempting to deploy a commit to the Docsify Team on Vercel.

A member of the Team first needs to authorize it.

@sy-records sy-records requested a review from paulhibbitts May 25, 2026 02:33
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docsify-preview Ready Ready Preview, Comment May 26, 2026 3:37am

paulhibbitts
paulhibbitts previously approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@paulhibbitts paulhibbitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this PR @sy-records ! I had a difficult time in trying to replicate search failures in codesandbox with a broken page so I created two GitHub Pages test repos based on the example provided by @kokovtsev after verifying locally.

Search index test (RC) - search for 'ipsum' fails:
https://github.com/paulhibbitts/docsify-v5-search-index-RC
https://paulhibbitts.github.io/docsify-v5-search-index-RC/#/

Search index test (PR preview build) - search for 'ipsum' succeeds:
https://github.com/paulhibbitts/docsify-v5-search-index-PR
https://paulhibbitts.github.io/docsify-v5-search-index-PR/#/

Hope you can also confirm these tests.

@sy-records
Copy link
Copy Markdown
Member Author

sy-records commented May 26, 2026

That's right.

@sy-records sy-records requested a review from paulhibbitts May 26, 2026 03:38
@sy-records sy-records changed the title fix: improve data saving logic in search.js feat(search): support embedded content full-text search and tolerate broken links May 26, 2026
@sy-records sy-records changed the title feat(search): support embedded content full-text search and tolerate broken links feat: support embedded content full-text search and tolerate broken links May 26, 2026
@sy-records sy-records changed the title feat: support embedded content full-text search and tolerate broken links feat: improve indexing and embedded search May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulhibbitts paulhibbitts Awaiting requested review from paulhibbitts

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search indexing does not work if some links are broken Allow full text search on embedded content

2 participants

@sy-records @paulhibbitts