Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
RunnerConfig.Envbehavior never allows clearing or fully overriding the inherited environment (an empty but non-nil slice behaves the same as nil); consider either documenting that explicitly or treating a non-nil slice (even if empty) as the complete environment to give callers more control. - Hard-coding
VLLM_HOST_IP=127.0.0.1in the vllm-metal backend may be too rigid if the bind address ever needs to vary (e.g., different network namespaces or non-localhost setups); it might be safer to derive this from configuration or a helper rather than embedding a literal.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `RunnerConfig.Env` behavior never allows clearing or fully overriding the inherited environment (an empty but non-nil slice behaves the same as nil); consider either documenting that explicitly or treating a non-nil slice (even if empty) as the complete environment to give callers more control.
- Hard-coding `VLLM_HOST_IP=127.0.0.1` in the vllm-metal backend may be too rigid if the bind address ever needs to vary (e.g., different network namespaces or non-localhost setups); it might be safer to derive this from configuration or a helper rather than embedding a literal.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to pass custom environment variables to backend processes and updates the macOS sandbox profile to allow outbound network connections and additional file access for the vLLM backend. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the backend runner configuration and updates the macOS sandbox policy to better support the
vllm-metalbackend. The main changes include allowing custom environment variables for backend processes, updating the sandbox to permit necessary network and file operations, and setting a required environment variable forvllm-metal.