Skip to content

fix: sandbox permissions#853

Open
ilopezluna wants to merge 1 commit intomainfrom
fix/vllm-metal-sandboxing
Open

fix: sandbox permissions#853
ilopezluna wants to merge 1 commit intomainfrom
fix/vllm-metal-sandboxing

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

This pull request enhances the backend runner configuration and updates the macOS sandbox policy to better support the vllm-metal backend. The main changes include allowing custom environment variables for backend processes, updating the sandbox to permit necessary network and file operations, and setting a required environment variable for vllm-metal.

@ilopezluna ilopezluna requested a review from a team April 10, 2026 11:14
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new RunnerConfig.Env behavior never allows clearing or fully overriding the inherited environment (an empty but non-nil slice behaves the same as nil); consider either documenting that explicitly or treating a non-nil slice (even if empty) as the complete environment to give callers more control.
  • Hard-coding VLLM_HOST_IP=127.0.0.1 in the vllm-metal backend may be too rigid if the bind address ever needs to vary (e.g., different network namespaces or non-localhost setups); it might be safer to derive this from configuration or a helper rather than embedding a literal.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `RunnerConfig.Env` behavior never allows clearing or fully overriding the inherited environment (an empty but non-nil slice behaves the same as nil); consider either documenting that explicitly or treating a non-nil slice (even if empty) as the complete environment to give callers more control.
- Hard-coding `VLLM_HOST_IP=127.0.0.1` in the vllm-metal backend may be too rigid if the bind address ever needs to vary (e.g., different network namespaces or non-localhost setups); it might be safer to derive this from configuration or a helper rather than embedding a literal.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to pass custom environment variables to backend processes and updates the macOS sandbox profile to allow outbound network connections and additional file access for the vLLM backend. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant