Persist compaction atomically - #4064
Merged
Merged
Conversation
krissetto
force-pushed
the
compaction-fix
branch
from
August 27, 2026 10:23
3705403 to
e843a05
Compare
aheritier
added
area/runtime
Contributor
Author
|
/review |
Contributor
|
👋 Heads up: The |
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
🟢 No issues found — LGTM! View logs.
Sayt-0
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist compaction summaries atomically with the session metadata, so manually and automatically compacted sessions restore correctly on session reload.
Currently if you reload a long session that has had compactions and you try to continue it, no compaction will be found, auto compaction will trigger on the full chat, and the request will fail if the full chat goes over the max context length of the model in use