fix(bridge): validate arguments of bridge subcommands - #14003
Open
glours wants to merge 1 commit into
Open
Conversation
`docker compose bridge transformations create` panicked with an index out of range when invoked without its PATH argument, as RunE indexed args[0] without any validator. Add cli.ExactArgs(1) so the CLI reports a proper usage error instead. Also add cobra.NoArgs to `bridge convert` and `bridge transformations list`, which silently ignored stray arguments. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
That was fast! :) ./bin/docker-compose bridge transformations create
# docker: 'docker compose bridge transformations create' requires 1 argument
# Usage: docker compose bridge transformations create [OPTION] PATH |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
docker compose bridge transformations createpanicked with an index out of range when invoked without its PATH argument, as RunE indexed args[0] without any validator. Add cli.ExactArgs(1) so the CLI reports a proper usage error instead.Also add cobra.NoArgs to
bridge convertandbridge transformations list, which silently ignored stray arguments.Related issue
https://docker.atlassian.net/browse/DDB-612
(not mandatory) A picture of a cute animal, if possible in relation to what you did
