connhelper: return original daemonURL for ssh host#7104
Open
SparshGarg999 wants to merge 1 commit into
Open
Conversation
This fixes issue docker#6164 where DaemonHost() returns the hardcoded http://docker.example.com dummy URL for SSH transport connection helpers. Returning the original daemonURL resolves incorrect host reporting and allows proper proxy key/NO_PROXY matching for SSH endpoints. Signed-off-by: Sparsh Garg <76697238+SparshGarg999@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed connection helper for SSH scheme to return the original daemonURL as the Host instead of the hardcoded dummy "http://docker.example.com". This fixes #6164.
- How I did it
Modified
getConnectionHelperincli/connhelper/connhelper.goto returnHost: daemonURLunderu.Scheme == "ssh". The URL parser and client transport will correctly cut the scheme and host, preserving the correct host for DaemonHost() and matching proxy settings (likeNO_PROXY), while keeping connection setup via SSH dialer intact.- How to verify it
Added a unit test
TestGetConnectionHelperincli/connhelper/connhelper_test.goverifying that the Host field matches the original SSH daemon URL.- Human readable description for the release notes