Add an AppOffline.htm when the local upgrade process is unpacking files#7328
Open
donker wants to merge 6 commits into
Open
Add an AppOffline.htm when the local upgrade process is unpacking files#7328donker wants to merge 6 commits into
donker wants to merge 6 commits into
Conversation
…l unpacking process. Also skip backing up main dlls during unpacking.
mitchelsellers
approved these changes
Jun 30, 2026
Contributor
|
Suggested testing notes. "New AppOffline process to show users that upgrades are in process using the upgrade experience. Ideally testing for any issues across different hosting environments; local, Microsoft Azure, Amazon Cloud, etc. Concern areas include unable to complete installations or hung-sites resulting in a manual removal of appoffline.htm" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR writes an AppOffline.htm to the root of DNN while a DNN install package is being written over the current installation. It ensures that another user can't access DNN while this process is going on.
Secondly this PR introduces "BackupFiles" as a boolean with default true to the FileInstaller allowing logic to skip backing up files. The local upgrade will not backup assemblies while installing as we do not support rolling back DNN installations to previous versions. The local upgrade process clearly states one should backup the entire installation before the upgrade commences.