Skip to content

[Automated] Merge CI changes into develop#7204

Closed
dnn-platform-ci-bot[bot] wants to merge 1 commit intodevelopfrom
automated/ci-125740
Closed

[Automated] Merge CI changes into develop#7204
dnn-platform-ci-bot[bot] wants to merge 1 commit intodevelopfrom
automated/ci-125740

Conversation

@dnn-platform-ci-bot
Copy link
Copy Markdown

Automated pull request created by CI build 125740.

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

Fixes #7187 issue with the Active Directory provider https://github.com/DNNCommunity/DNN.ActiveDirectory as well as other providers and potentially other usages of that control.
@bdukes bdukes force-pushed the automated/ci-125740 branch from 9457a57 to 7d79c4e Compare April 14, 2026 13:23
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    1 files  ±0      1 suites  ±0   1m 19s ⏱️ +4s
2 581 tests ±0  2 569 ✅ ±0  12 💤 ±0  0 ❌ ±0 
2 904 runs  ±0  2 892 ✅ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 7d79c4e. ± Comparison against base commit eb221cd.

This pull request removes 64 and adds 64 tests. Note that renamed tests count towards both.
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_en_US("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_fr_FR("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_he_IL("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ru_RU("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_tr_TR("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_zh_CN("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,04/09/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
…
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_en_US("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_fr_FR("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_he_IL("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_ru_RU("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_tr_TR("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ GetSettings_GetsValuesFrom_ModuleSettingsCollection_zh_CN("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ar_JO("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
DotNetNuke.Tests.Core.Entities.Modules.Settings.ModuleSettingsTests ‑ SaveSettings_CallsUpdateModuleSetting_WithRightParameters_ca_ES("Bsskk41233[]#%&",-5,-13456.456d,True,04/13/2026 00:00:00,1.05:06:07,Value2,DotNetNuke.Tests.Core.Entities.Modules.Settings.ComplexType)
…

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Apr 14, 2026

From a commit history standpoint, I am not sure if we should merge this or merge the whole branch into develop before release. Let's hold on this for now.

@bdukes
Copy link
Copy Markdown
Contributor

bdukes commented Apr 14, 2026

Should this PR have been opened against release/10.3.1, since that's where the commit that triggered it was? Or should this action not run at all if it's not a change on develop?

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Apr 15, 2026

Sooo, the general idea was to not forget the sqldataprovider files. They are generated during builds but often a developer will add a IUpgradeable and either not run a full build or not commit the empty sqlDataProvider file. Also, the logic was expanded since we know an RC is out or a new release is out, to auto-update the bug report issue template.

My initial logic was that all generated files that are not gitignored should probably be included in such PR. But now that we see this, we may not always want to include it all every time.

I am thinking either we filter what gets included to only the bug template and sql data provider files. Or maybe split this into 2 PRs one for each purpose with a better title appropriate to its purpose?

@valadas
Copy link
Copy Markdown
Contributor

valadas commented Apr 15, 2026

I said IUpgradeable but not sure now which part depends on sqldataprovider existing, I may be confused with xmlmerge scripts or something. Whatever was tied into the existance of such sqldataprovider file. It would actually be great to remove that dependency so we don't need those empty files in the first place.

@valadas valadas closed this Apr 15, 2026
@bdukes bdukes deleted the automated/ci-125740 branch April 15, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants