[Automated] Merge CI changes into develop#7204
[Automated] Merge CI changes into develop#7204dnn-platform-ci-bot[bot] wants to merge 1 commit intodevelopfrom
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Fixes #7187 issue with the Active Directory provider https://github.com/DNNCommunity/DNN.ActiveDirectory as well as other providers and potentially other usages of that control.
9457a57 to
7d79c4e
Compare
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Test Results 1 files ±0 1 suites ±0 1m 19s ⏱️ +4s Results for commit 7d79c4e. ± Comparison against base commit eb221cd. This pull request removes 64 and adds 64 tests. Note that renamed tests count towards both. |
|
From a commit history standpoint, I am not sure if we should merge this or merge the whole branch into develop before release. Let's hold on this for now. |
|
Should this PR have been opened against |
|
Sooo, the general idea was to not forget the sqldataprovider files. They are generated during builds but often a developer will add a IUpgradeable and either not run a full build or not commit the empty sqlDataProvider file. Also, the logic was expanded since we know an RC is out or a new release is out, to auto-update the bug report issue template. My initial logic was that all generated files that are not gitignored should probably be included in such PR. But now that we see this, we may not always want to include it all every time. I am thinking either we filter what gets included to only the bug template and sql data provider files. Or maybe split this into 2 PRs one for each purpose with a better title appropriate to its purpose? |
|
I said IUpgradeable but not sure now which part depends on sqldataprovider existing, I may be confused with xmlmerge scripts or something. Whatever was tied into the existance of such sqldataprovider file. It would actually be great to remove that dependency so we don't need those empty files in the first place. |
Automated pull request created by CI build 125740.