Refactor synced repo URL handling in skill cards#84
Open
dirtybits wants to merge 1 commit into
Open
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_187c949c-e4a7-4781-a925-52fba22705d9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillPreviewCardandSkillDetailClientinstead of recomputing them during render.Verification
npm exec --workspace @agentvouch/web -- vitest run __tests__/components/skill-preview-card-source.test.ts __tests__/lib/mirror-connectedRepos.test.tsgit diff --checkNotes
npm exec --workspace @agentvouch/web -- tsc --noEmitstill fails in this worktree on an existing unrelated module-resolution error for@vercel/speed-insights/nextinapp/layout.tsx. The change itself is lint-clean and the targeted tests passed.Note
Low Risk
Display-only refactor with no API or data changes; synced badge rules stay tied to
sanitizeSyncedRepoUrland mirror exclusion.Overview
Skill detail and preview cards now derive a single
syncedRepoUrl(sanitized GitHub HTTPS URL for non-mirror skills) instead of a boolean plus repeatedsanitizeSyncedRepoUrlcalls in JSX.The Synced GitHub badge still appears only when that value is truthy; mirror skills still skip sync provenance. User-visible behavior is unchanged—this is a small render-path cleanup in
SkillDetailClientandSkillPreviewCard.Reviewed by Cursor Bugbot for commit b8e522c. Bugbot is set up for automated code reviews on this repo. Configure here.