Update blowdryer-diffplug to 9.1.0 to fix publishing - #42
Merged
Conversation
The 9.0.0 scripts still pointed at s01.oss.sonatype.org, which is dead and now answers with a 402, so `initializeSonatypeStagingRepository` failed the last deploy. 9.0.4 moved to the central portal urls. Also swaps the deploy workflow's `GH_TOKEN` PAT for the built-in `GITHUB_TOKEN`. The last deploy died before it got that far, so the PAT wasn't exercised, but it was last set 2024-01-23 and goomph needed this same swap to get its deploys green after the sonatype migration. Deploy stays on JVM 11 (unlike goomph) because `spotlessFreshmark` is disabled on Java 12+ here, and `changelogBumpFreshmark` has to run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011wHkSPGLE7g451CaG9q1nD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failed deploy in run 32311994888:
We were pinned to blowdryer-diffplug
9.0.0, whosebase/sonatype.gradlestill points ats01.oss.sonatype.org. That host is dead —9.0.4moved to the central portal urls.Changes
9.0.0→9.1.0— picks up the sonatype url fix (9.0.4), thechangelogBumpFreshmarkGitAddGradle-9 warning fix (9.0.5), and the spotless deprecation fixes (9.0.1/9.0.2).plugin.versions— spotless7.0.3→7.2.1, pluscom.gradle.develocity 4.1.1. Required;setPluginsBlockTofails the build on mismatch.base/buildscan-on-ci.gradleapplied — the 9.1.0 feature the develocity plugin is there for. Scans publish only whenCIis set. Matches goomph'ssettings.gradle.secrets.GH_TOKEN→secrets.GITHUB_TOKENindeploy.yml. The deploy died before reaching the GitHub-release step so the PAT was never exercised, but it was last set 2024-01-23 and goomph needed this same swap to get green after the sonatype migration. Repo workflow permissions are alreadywrite, andchangelogPushtargetsrelease, not protectedmain.Deploy stays on JVM 11 (goomph moved to 17) because this repo's
build.gradledisablesspotlessFreshmarkon Java 12+, andchangelogBumpFreshmarkneeds to run to bump the README version links.Gradle wrapper left at 8.10.2 — goomph publishes fine on 8.10.1.
Verification
./gradlew buildconfigures cleanly and all tests pass exceptBlowdryerPluginTest.tooOldError, which fails identically on unmodifiedmain: it drives Gradle 6.7 through TestKit, and 6.7's Groovy can't read Java 21 class files (Unsupported class file major version 65). ItsAssumeonly guards Java 17, so it's a local-JDK artifact — CI runs 11 and 17. The'indentWithSpaces' is deprecatedwarnings from the failed run are gone.The failed run left nothing to clean up:
mainandreleasewere both at3f631cc, and norelease/1.7.2tag was created.🤖 Generated with Claude Code
https://claude.ai/code/session_011wHkSPGLE7g451CaG9q1nD