Support 1-bit signed bitvectors in bv_utilst::lt_or_le#8998
Merged
tautschnig merged 1 commit intodevelopfrom May 4, 2026
Merged
Support 1-bit signed bitvectors in bv_utilst::lt_or_le#8998tautschnig merged 1 commit intodevelopfrom
bv_utilst::lt_or_le#8998tautschnig merged 1 commit intodevelopfrom
Conversation
bv_utilst::lt_or_le
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8998 +/- ##
========================================
Coverage 80.51% 80.52%
========================================
Files 1704 1705 +1
Lines 188874 188927 +53
Branches 73 73
========================================
+ Hits 152076 152131 +55
+ Misses 36798 36796 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add early return for the 1-bit signed case before the compact encoding that requires >= 2 bits. Add unit test.
e62edfe to
648e9ae
Compare
tautschnig
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compact signed comparison encoding in
lt_or_lerequired at least 2 bits, rejecting 1-bit signed bitvectors with an INVARIANT failure. A 1-bit signed bitvector represents {0, -1}, so comparison reduces to sign-bit logic.Changes
<and<=)Testing
unit/solvers/flattening/bv_utils.cpp(6 assertions, all pass)