Fix unnecessary irept copies found by check-irep-moves#8978
Open
tautschnig wants to merge 2 commits intodiffblue:developfrom
Open
Fix unnecessary irept copies found by check-irep-moves#8978tautschnig wants to merge 2 commits intodiffblue:developfrom
tautschnig wants to merge 2 commits intodiffblue:developfrom
Conversation
Address 8 findings from the clang-based irept copy checker: - 1 const reference (shadow_memory_util.cpp: unmodified copy) - 7 std::move (string_abstraction, goto_convert_side_effect, string_instrumentation, value_set, boolbv_extractbit, boolbv_index: source not used after copy) Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
Heuristic grep-based checker that flags local variables initialized by copying an irept-derived type, where the variable is subsequently modified and the source appears unused after the copy. These are candidates for std::move to avoid unnecessary copy-on-write detach. Found 22 candidates in goto-symex, 50 across the hot paths. Each needs manual review — some are false positives (const ref sources, loop-reused sources). Usage: python3 scripts/check_irep_copies.py src/goto-symex/*.cpp Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
a team,
kroening,
martin-cs,
peterschrammel and
remi-delmas-3000
as code owners
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #8978 +/- ##
========================================
Coverage 80.50% 80.50%
========================================
Files 1704 1704
Lines 188778 188778
Branches 73 73
========================================
Hits 151975 151975
Misses 36803 36803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address 8 findings from the clang-based irept copy checker: