Skip to content

chore(Core): Limit wasm locals #2#10816

Merged
michael-weigelt merged 2 commits into
masterfrom
mwe/limit_locals_2
Jul 20, 2026
Merged

chore(Core): Limit wasm locals #2#10816
michael-weigelt merged 2 commits into
masterfrom
mwe/limit_locals_2

Conversation

@michael-weigelt

@michael-weigelt michael-weigelt commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Essentially reverts this revert: #10475
Metrics show that this is almost twice the max of existing canisters over all subnets.

@github-actions github-actions Bot added the chore label Jul 17, 2026
@michael-weigelt
michael-weigelt marked this pull request as ready for review July 20, 2026 07:22
@michael-weigelt
michael-weigelt requested a review from a team as a code owner July 20, 2026 07:22
@zeropath-ai

zeropath-ai Bot commented Jul 20, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to a98cb31.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/embedders/src/wasm_utils/validation.rs
      Add MAX_WASM_FUNCTION_NUM_LOCALS constant
► rs/embedders/tests/validation.rs
      Add test wasm_with_many_locals_is_invalid
Bug Fix ► rs/types/wasm_types/src/errors.rs
      Introduce TooManyLocals error variant and display/help text

@schneiderstefan schneiderstefan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention in the description that this is more than any existing canisters are using, according to the metrics.

@michael-weigelt
michael-weigelt added this pull request to the merge queue Jul 20, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 20, 2026
@michael-weigelt
michael-weigelt added this pull request to the merge queue Jul 20, 2026
Merged via the queue into master with commit 543f299 Jul 20, 2026
42 checks passed
@michael-weigelt
michael-weigelt deleted the mwe/limit_locals_2 branch July 20, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants