feat: Drop blessed versions from a few components#10366
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
There was a problem hiding this comment.
Pull request overview
Updates recovery/replay tooling to align with the new “elected replica versions” workflow by removing explicit “bless” handling and renaming related flags/steps accordingly.
Changes:
- Renames CLI flags/params from “add-and-bless …” to “add …” in recovery tests and tooling.
- Removes ic-replay logic for fetching/updating
BlessedReplicaVersionsand the corresponding “bless” ingress mutation. - Updates recovery step naming/wording to reflect “elect” terminology (with a few remaining user-facing strings to fix).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rs/tests/nested/nns_recovery/common.rs | Switches test config wiring from add_and_bless_upgrade_version to add_upgrade_version. |
| rs/tests/consensus/subnet_recovery/utils.rs | Updates param destructuring / CLI arg generation for the renamed add_upgrade_version option. |
| rs/replay/src/player.rs | Removes registry query helper for BlessedReplicaVersions and related imports. |
| rs/replay/src/ingress.rs | Drops “bless replica version” ingress mutation; only adds version record + updates subnet record. |
| rs/replay/src/cmd.rs | Renames replay subcommand flag to --add-replica-version. |
| rs/registry/regedit/src/protobuf.rs | Removes protobuf transformer support for BlessedReplicaVersions. |
| rs/recovery/src/nns_recovery_same_nodes.rs | Renames CLI arg to --add-upgrade-version and updates prompts/field name. |
| rs/recovery/src/nns_recovery_failover_nodes.rs | Updates operator-facing text from “blessed” to “elected”. |
| rs/recovery/src/lib.rs | Propagates renamed bool into ic-replay subcommand construction and description string. |
| rs/recovery/src/app_subnet_recovery.rs | Renames BlessVersion step to ElectVersion and updates step docs (but some prompts still say “bless”). |
Comments suppressed due to low confidence (1)
rs/recovery/src/app_subnet_recovery.rs:368
- User-facing prompts in this step still refer to “bless” even though the step/terminology has been renamed to “elect”. This is confusing for operators and contradicts the updated StepType name.
StepType::ElectVersion => {
if self.params.upgrade_version.is_none() {
self.params.upgrade_version =
read_optional(&self.logger, "Version to bless (and upgrade to): ");
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ReplicaVersionRecords and the blessed versions list are updated in sync, as we no longer require an extra proposal to have each version "blessed".
This updates a few tools with the change.