Skip to content

feat: Drop blessed versions from a few components#10366

Merged
Bownairo merged 3 commits into
masterfrom
eero/blessed-versions-7
Jun 3, 2026
Merged

feat: Drop blessed versions from a few components#10366
Bownairo merged 3 commits into
masterfrom
eero/blessed-versions-7

Conversation

@Bownairo
Copy link
Copy Markdown
Contributor

@Bownairo Bownairo commented Jun 1, 2026

ReplicaVersionRecords and the blessed versions list are updated in sync, as we no longer require an extra proposal to have each version "blessed".

This updates a few tools with the change.

@github-actions github-actions Bot added the feat label Jun 1, 2026
@Bownairo Bownairo marked this pull request as ready for review June 1, 2026 19:09
@Bownairo Bownairo requested review from a team as code owners June 1, 2026 19:09
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@Bownairo Bownairo dismissed github-actions[bot]’s stale review June 1, 2026 19:15

Tooling changes only.

@Bownairo Bownairo requested a review from bjoernek June 2, 2026 00:43
Copy link
Copy Markdown
Contributor

@pierugo-dfinity pierugo-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates recovery/replay tooling to align with the new “elected replica versions” workflow by removing explicit “bless” handling and renaming related flags/steps accordingly.

Changes:

  • Renames CLI flags/params from “add-and-bless …” to “add …” in recovery tests and tooling.
  • Removes ic-replay logic for fetching/updating BlessedReplicaVersions and the corresponding “bless” ingress mutation.
  • Updates recovery step naming/wording to reflect “elect” terminology (with a few remaining user-facing strings to fix).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rs/tests/nested/nns_recovery/common.rs Switches test config wiring from add_and_bless_upgrade_version to add_upgrade_version.
rs/tests/consensus/subnet_recovery/utils.rs Updates param destructuring / CLI arg generation for the renamed add_upgrade_version option.
rs/replay/src/player.rs Removes registry query helper for BlessedReplicaVersions and related imports.
rs/replay/src/ingress.rs Drops “bless replica version” ingress mutation; only adds version record + updates subnet record.
rs/replay/src/cmd.rs Renames replay subcommand flag to --add-replica-version.
rs/registry/regedit/src/protobuf.rs Removes protobuf transformer support for BlessedReplicaVersions.
rs/recovery/src/nns_recovery_same_nodes.rs Renames CLI arg to --add-upgrade-version and updates prompts/field name.
rs/recovery/src/nns_recovery_failover_nodes.rs Updates operator-facing text from “blessed” to “elected”.
rs/recovery/src/lib.rs Propagates renamed bool into ic-replay subcommand construction and description string.
rs/recovery/src/app_subnet_recovery.rs Renames BlessVersion step to ElectVersion and updates step docs (but some prompts still say “bless”).
Comments suppressed due to low confidence (1)

rs/recovery/src/app_subnet_recovery.rs:368

  • User-facing prompts in this step still refer to “bless” even though the step/terminology has been renamed to “elect”. This is confusing for operators and contradicts the updated StepType name.
            StepType::ElectVersion => {
                if self.params.upgrade_version.is_none() {
                    self.params.upgrade_version =
                        read_optional(&self.logger, "Version to bless (and upgrade to): ");
                }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rs/recovery/src/nns_recovery_same_nodes.rs
Comment thread rs/replay/src/cmd.rs
Comment thread rs/recovery/src/app_subnet_recovery.rs
@Bownairo Bownairo enabled auto-merge June 3, 2026 17:12
@Bownairo Bownairo added this pull request to the merge queue Jun 3, 2026
Merged via the queue into master with commit 7e3b8e3 Jun 3, 2026
76 of 78 checks passed
@Bownairo Bownairo deleted the eero/blessed-versions-7 branch June 3, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants