Skip to content

fix: update SparseEncodingEncoderTest for #232 MaskedArray wrapping #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jul 8, 2026
Merged

fix: update SparseEncodingEncoderTest for #232 MaskedArray wrapping #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions writer/src/test/java/io/github/dfa1/vortex/writer/encode/SparseEncodingEncoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,13 @@ void decode_utf8_noPatches_allEmpty() {
// When
Array result = DECODER.decode(ctx);

// Then
// Then — null fill wraps the VarBin values in a MaskedArray whose rows are all
// invalid (#232); the inner values are still zero-length strings.
assertThat(result.length()).isEqualTo(3L);
VarBinArray varBin = (VarBinArray) result;
MaskedArray masked = (MaskedArray) result;
VarBinArray varBin = (VarBinArray) masked.inner();
for (int i = 0; i < 3; i++) {
assertThat(masked.isValid(i)).as("valid index %d", i).isFalse();
assertThat(varBin.getByteLength(i)).as("index %d", i).isZero();
}
}
Expand Down Expand Up @@ -375,14 +378,18 @@ void decode_utf8_withPatches_writesStringsAtIndices() {
// When
Array result = DECODER.decode(ctx);

// Then
VarBinArray varBin = (VarBinArray) result;
// Then — null fill: unpatched rows 0/2/4 are null, patched rows 1/3 carry the
// strings and are valid (#232). Unwrap the MaskedArray to reach the VarBin values.
MaskedArray masked = (MaskedArray) result;
VarBinArray varBin = (VarBinArray) masked.inner();
assertThat(varBin.length()).isEqualTo(5L);
assertThat(varBin.getByteLength(0)).isZero();
assertThat(masked.isValid(0)).isFalse();
assertThat(masked.isValid(1)).isTrue();
assertThat(varBin.getString(1)).isEqualTo("hi");
assertThat(varBin.getByteLength(2)).isZero();
assertThat(masked.isValid(2)).isFalse();
assertThat(masked.isValid(3)).isTrue();
assertThat(varBin.getString(3)).isEqualTo("bye");
assertThat(varBin.getByteLength(4)).isZero();
assertThat(masked.isValid(4)).isFalse();
}

@Test
Expand Down
Loading