fixed pgAdmin macOS dmg installation#2018
Conversation
Coverage Report for CI Build 27744303111Coverage decreased (-0.06%) to 71.242%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions248 previously-covered lines in 4 files lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
left a comment
There was a problem hiding this comment.
@shodiBoy1 thanks for analysing and fixing this bug.
The code looks quite redundant to already existing code (e.g. to "extract dmg", the installation routine or to prompt when running privileged operations). I got the impression that we need to understand the root cause properly and fix the bug trying to avoid the copy&paste. I hope we will soon meet in a daily or otherwise to clarify this.
|
Thanks for the review, i reworked it to fix the root cause and reused existing code instead of copying it.
Tested on Mac (arm64):
|
Removed duplicate entry for issue devonfw#1906 regarding 'ide uninstall' failing on macOS.
This PR fixes #798 and #878
Implemented changes:
Testing instructions
Check out the PR:
Automated tests (any OS)
mvn -pl cli -Dtest=PgAdminTest,GlobalToolCommandletTest testManual test (macOS)
The install copies the app to /Applications with sudo, so it has to run in a real terminal (the IntelliJ Run console can't enter a sudo password).
You should see it download the dmg, print the privileged commands, ask for your password, copy pgAdmin 4.app into /Applications, and start pgAdmin.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal