Skip to content

#1965: improve dependent installations #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdemZarrouki wants to merge 8 commits into
base: main
Choose a base branch
from
Open

#1965: improve dependent installations #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7eaf8cf
#1965: Add ToolInstallRequest to PackageManagerRequest
AdemZarrouki Jun 9, 2026
0ceba4c
#1965: Add Javadoc for getter and setter of toolInstallRequest
AdemZarrouki Jun 9, 2026
2556834
Revert "#1965: Add Javadoc for getter and setter of toolInstallRequest"
AdemZarrouki Jun 11, 2026
bcfcaf9
Revert "#1965: Add ToolInstallRequest to PackageManagerRequest"
AdemZarrouki Jun 11, 2026
14bd74e
#1965: fix redundant call of npm and node when installing npm based c…
AdemZarrouki Jun 11, 2026
1c2bfa0
#1965: update changelog
AdemZarrouki Jun 12, 2026
1b44516
Merge branch 'main' into feature/1965-improve-dependent-installations
AdemZarrouki Jun 16, 2026
974ca4b
Merge branch 'main' into feature/1965-improve-dependent-installations
AdemZarrouki Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Release with new features and bugfixes:
* https://github.com/devonfw/IDEasy/issues/1719[#1719]: Add Rust and MSVC support
* https://github.com/devonfw/IDEasy/issues/1991[#1991]: Improve WindowsHelperMock
* https://github.com/devonfw/IDEasy/issues/1457[#1457]: Improve CLI error messages on invalid args or commandlets not available in current context
* https://github.com/devonfw/IDEasy/issues/1965[#1965]: Improve dependent installations for npm and pip based commandlets

The full list of changes for this release can be found in https://github.com/devonfw/IDEasy/milestone/45?closed=1[milestone 2026.06.001].

Expand Down
8 changes: 7 additions & 1 deletion cli/src/main/java/com/devonfw/tools/ide/tool/npm/NpmBasedCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ private VersionIdentifier runPackageManagerGetInstalledVersion(String npmPackage
ProcessContext pc = this.context.newProcess().errorHandling(ProcessErrorHandling.THROW_CLI)
.withExitCodeAcceptor(rc -> true); // if the tool is not installed npm list will end with exit code 1
request.setProcessContext(pc);
ProcessResult result = runPackageManager(request);
ProcessResult result = runPackageManager(request, true);
if (result.isSuccessful()) {
List<String> versions = result.getOut();
String parsedVersion = null;
Expand All @@ -84,4 +84,10 @@ private VersionIdentifier runPackageManagerGetInstalledVersion(String npmPackage
return null;
}

@Override
protected boolean isSkipInstallation() {
Npm npm = this.context.getCommandletManager().getCommandlet(Npm.class);
return npm.isInstalled();
}

}
2 changes: 1 addition & 1 deletion cli/src/main/java/com/devonfw/tools/ide/tool/pip/PipBasedCommandlet.java
View file
Open in desktop

@laert-ll laert-ll Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any particular reason why Pip doesn't override isSkipInstallation() in the same way that Npm does?

@AdemZarrouki AdemZarrouki Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because i didn't found a loop dependency that can occurs in pip context.

@AdemZarrouki AdemZarrouki Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding tests i will add some junit tests in NgTest and NestTest

Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ protected VersionIdentifier computeInstalledVersion() {
}
PackageManagerRequest request = new PackageManagerRequest("show", getPackageName()).setProcessMode(ProcessMode.DEFAULT_CAPTURE)
.setProcessContext(this.context.newProcess().errorHandling(ProcessErrorHandling.NONE));
ProcessResult processResult = runPackageManager(request);
ProcessResult processResult = runPackageManager(request, true);
if (processResult.isSuccessful()) {
for (String line : processResult.getOut()) {
// we are looking for something like "Version: 25.3"
Expand Down
Loading