fix: add connect timeout so ureq can fail over to other DNS IPs - #359
Merged
Conversation
plutonium-239
force-pushed
the
fix/connect-timeout
branch
from
August 27, 2026 10:05
c44b955 to
121b218
Compare
plutonium-239
changed the title
Owner
|
Hi @plutonium-239 and thanks for your PR! The change seems reasonable, but could you lower the connect timeout to 2 seconds? After that I will merge and release a new |
Contributor
Author
|
Done @devmatteini! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #358.
Adds a
connect_timeoutto theureq::Agent.This allows
ureqto try the remaining resolved IPs transparently.I've built and tested it - it waits the 5s, then starts downloading. No log/output/warning printed to the terminal.