Test/add bats suite and ci#5
Merged
Merged
Conversation
The step had no automated tests (bitrise.yml's "test" workflow only echoes).
Add a BATS suite mirroring the Bitbucket pipe's pattern, stubbing `npx`
(cloud/status) and `envman` so it runs offline. step.sh is executed under
`bash` to match Bitrise's `toolkit: bash` (the #!/bin/sh shebang is unused by
Bitrise). A GitHub Actions workflow runs the suite on push/PR, plus an
advisory shellcheck (as bash).
12 tests cover command composition (apiKey + positional args, package/version
selection, device/value flags, boolean flags, env_list/metadata splitting),
the console URL output, and exit-code propagation from the cloud command.
2 tests are skipped to document a real bug the suite surfaced: step.sh greps
COMPACT-JSON patterns ('"status":"..."') against `dcd status --json`, which is
pretty-printed (JSON.stringify(obj, null, 2)). The patterns never match, so
DEVICE_CLOUD_UPLOAD_STATUS / FLOW_RESULTS are emitted empty and
APP_BINARY_ID is omitted. Exit codes are unaffected (driven by the cloud
command's own exit code). Unskip once the parser handles the real output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.