Enforce code style with prettier and eslint. #136

Activity

1. rmariuzzo commented on Apr 3, 2020

   

   rmariuzzo

   on Apr 3, 2020 via email

   Member

   More actions

   Sounds good to me

   …

   On Fri, Apr 3, 2020, 09:57 David Mateo ***@***.***> wrote: Hello. I would like to test this project and later contribute if needed but I think this needs a prettier or eslint config to enforce the recommended code-style. This worked on my build at the end of package.json, have to do more tests. "prettier": { "printWidth": 120, "tabWidth": 1, "singleQuote": true, "trailingComma": "none", "semi": false }, "eslintConfig": { "parserOptions": { "ecmaVersion": 8, "sourceType": "module" }, "rules": { "semi": ["error", "never"] } } I think some system like this would provide consistency and less headaches when people save and have auto format on vs code and such. What do you think? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#136>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADLMH3QGPRGDSVMHPXMNIDRKXTOLANCNFSM4L4BODBA> .
2. DannyFeliz commented on Apr 3, 2020

   

   DannyFeliz

   on Apr 3, 2020

   Member

   More actions

   Hey @rmariuzzo could you please check this PR #133?
3. david-mateogit commented on Apr 3, 2020

   

   david-mateogit

   on Apr 3, 2020

   Author

   More actions

   Sounds good to me
   …

   Great.
   I'll do some tests and send a pr later.

   BTW as a DR Dev I thank you for this.