Skip to content

Say why when a remote review's host is down, in Source windows, Ask and Source tree - #974

Merged
thesiti92 merged 10 commits into
remote/11-host-statusfrom
remote/12-host-down-surfaces
Oct 14, 2026
Merged

Say why when a remote review's host is down, in Source windows, Ask and Source tree#974
thesiti92 merged 10 commits into
remote/11-host-statusfrom
remote/12-host-down-surfaces

Conversation

@thesiti92

@thesiti92 thesiti92 commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

When a remote review's host is down, the other surfaces say so and offer the next step, instead of failing slowly or silently.

  • Source windows show the host's state in the status bar. While it is offline, the notice and the status bar offer Retry. Other states are text only. A second outage notifies again.
  • Opening source on a host that is known to be down fails at once with the reason and Retry, instead of waiting up to 60 seconds. The canvas callers no longer leave unhandled rejections.
  • Ask blocks its input while the host is down and shows a status banner with the next step. A question is never queued. Every failed Ask request offers Try again. A 5xx from the agent list keeps the last list, so Ask does not disappear.
  • Source tree stays visible on remote reviews and is disabled, with the reason, only when a Source window cannot open. The checkout banner names the host, and a failed Dismiss shows its error.
  • SSH failures read as plain sentences: refused, unknown host name, timed out, key not accepted, host key changed, and a dropped connection (" stopped answering over SSH.").

Stacked on #973.

Test plan

  • Pause a host with Ask open on its review: the input is disabled and the banner shows the reason with Retry; Source tree is disabled with the reason as its tooltip; Dismiss stays visible.
  • Wait about a minute: the host's detail reads " stopped answering over SSH. It may be asleep, or off this network."
  • With a Source window open, pause its host: the status bar and the notice offer Retry. Resume, then pause again: a second notice appears.
  • Open file on a paused host's review: a notice with Retry appears at once.
  • remote-host journey passes.

@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from 3bf5591 to 9a7c2d8 Compare October 7, 2026 13:39
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from 9a7c2d8 to 64571e9 Compare October 7, 2026 14:59
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from 64571e9 to 491ca94 Compare October 8, 2026 12:59
@thesiti92 thesiti92 mentioned this pull request Oct 8, 2026
Closed
4 tasks
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from 491ca94 to e7f38fb Compare October 8, 2026 13:10
@thesiti92 thesiti92 mentioned this pull request Oct 8, 2026
Merged
1 task done
thesiti92 added a commit that referenced this pull request Oct 8, 2026
@thesiti92
Wait a frame for Find's active highlight in its browser test (#1033)
56af877 
Find sets the active match's highlight in a `requestAnimationFrame`
after the match count updates. The browser test read its colour right
after the count, so it failed on loaded CI runners (seen twice on the
remote stack, #938 and #974). The assertion now waits for it.

## Test plan
- [x] `src/review-find-controller.browser.test.tsx` passes locally.
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch 2 times, most recently from b48915f to c77fa01 Compare October 11, 2026 13:34
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from c77fa01 to 815cd30 Compare October 13, 2026 14:44
@thesiti92
thesiti92 added this pull request to stack #1105 October 13, 2026 15:38
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from 815cd30 to 089ca1e Compare October 13, 2026 16:00
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch 2 times, most recently from a30078e to b7255b3 Compare October 13, 2026 17:38
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from b7255b3 to d4d6b79 Compare October 13, 2026 21:49
@thesiti92
thesiti92 removed this pull request from stack #1105 October 13, 2026 22:42
@thesiti92
thesiti92 added this pull request to stack #1117 October 13, 2026 22:42
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from d4d6b79 to a094dab Compare October 13, 2026 22:53
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from a094dab to 8bfb9f6 Compare October 13, 2026 22:54
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch 2 times, most recently from e0dab0d to a15032d Compare October 14, 2026 19:37
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch 2 times, most recently from 4b20619 to b88ee6e Compare October 14, 2026 19:53
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from b88ee6e to 3a90432 Compare October 14, 2026 19:55
@thesiti92
thesiti92 removed this pull request from stack #1117 October 14, 2026 20:13
@thesiti92
thesiti92 added this pull request to stack #1131 October 14, 2026 20:14
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from ed83e74 to a420031 Compare October 14, 2026 20:18
@thesiti92
thesiti92 marked this pull request as ready for review October 14, 2026 20:20
@thesiti92
Show a Source window's host state, with Retry while offline
5c67e94 
The status bar and the notice use the host's own words, such as
"Can't sign in to alex-box", instead of "offline, reconnecting…" for
every state. While the host is offline, both offer Retry. A later
outage in the same window notifies again.

Agent-Session: 3a3376c5-3f72-46df-930c-a66d5c3bcce5
Agent-Session: 7633c50b-998d-4b1e-8ca2-ffb350a26066
Agent-Session: 9a4d92ed-7a0d-42a1-9169-574bca60095b
Agent-Session: 1c093463-922b-435b-a925-664d5d5c3c0a
Agent-Session: 2b51b153-90b5-4a72-a052-fccf0beb9f1c
@thesiti92
Fail at once when opening source on a host that is down
3081e5a 
Opening a remote review's source used to wait up to a minute and then
show the raw error. When the host is known to be down it now fails at
once, with the host's words and Retry. The canvas no longer leaves the
rejection unhandled.

Agent-Session: 3a3376c5-3f72-46df-930c-a66d5c3bcce5
Agent-Session: 7633c50b-998d-4b1e-8ca2-ffb350a26066
Agent-Session: 9a4d92ed-7a0d-42a1-9169-574bca60095b
Agent-Session: 1c093463-922b-435b-a925-664d5d5c3c0a
Agent-Session: 2b51b153-90b5-4a72-a052-fccf0beb9f1c
@thesiti92
Block Ask while a review's host is down
63ca2db 
The input is disabled and a banner says why, with the step that helps.
A question is never queued. A failed request offers Try again, and a
host that cannot list its agents for now keeps the last list, so Ask
does not disappear.

Agent-Session: 7633c50b-998d-4b1e-8ca2-ffb350a26066
Agent-Session: 9a4d92ed-7a0d-42a1-9169-574bca60095b
Agent-Session: 1c093463-922b-435b-a925-664d5d5c3c0a
Agent-Session: 2b51b153-90b5-4a72-a052-fccf0beb9f1c
@thesiti92
Say why SSH could not reach a host in a plain sentence
8c90e7a 
Common OpenSSH failures read as one sentence naming the host: refused,
unknown host name, timed out, key not accepted, host key changed, and
a connection that stopped answering. Other failures keep OpenSSH's
words. The raw output stays in the log.

Agent-Session: 7633c50b-998d-4b1e-8ca2-ffb350a26066
Agent-Session: 9a4d92ed-7a0d-42a1-9169-574bca60095b
Agent-Session: 1c093463-922b-435b-a925-664d5d5c3c0a
Agent-Session: 2b51b153-90b5-4a72-a052-fccf0beb9f1c
@thesiti92
Keep Source tree on remote reviews, disabled with the reason
3c3e810 
The gateway gives a remote review's availability a reason: the host's
sentence while it is down, or why its VS Code server is unavailable.
Source tree stays in the top bar and is disabled with that reason as its
tooltip, instead of disappearing. Missing language extensions do not
disable it.
@thesiti92
Name the host when a remote review's checkout is gone
797d1fa 
The checkout banner and the lenses say "The checkout on <host> is
unavailable." for a remote review, not "Local checkout unavailable."
A failed Dismiss shows its error in the banner instead of only logging
it.
@thesiti92
Match the Source window's offline label in the journey
176c250
@thesiti92
Show a restored Source window's host offline before its alias attaches
8545088
@thesiti92
Let the gateway's 503 say a source's host is down
e2b64de 
The gateway answers a down host's review at once with 503 and its alias, so the navigator no longer checks the catalog first.
@thesiti92
Shorten a host state comment
13f0aef
@thesiti92
thesiti92 removed this pull request from stack #1131 October 14, 2026 20:44
@thesiti92
thesiti92 force-pushed the remote/12-host-down-surfaces branch from a420031 to 13f0aef Compare October 14, 2026 20:44
@thesiti92
thesiti92 added this pull request to stack #1134 October 14, 2026 20:44
@thesiti92
thesiti92 merged commit 08879ba into main Oct 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidkmenon sidkmenon sidkmenon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thesiti92 @sidkmenon