Repository navigation
Give Ask agents Whiteboard's writing guidance - #955
Merged
Merged
Conversation
An Ask agent answering inline never called session_get_instructions, so it got none of Whiteboard's guidance. Its first prompt now carries the style that applies to an inline answer, and points it at session_get_instructions before it edits the review, for the guidelines and component fields. Agent-Session: d4745dd1-0fc1-49ef-8545-286495939081 Agent-Session: b0dfef22-75f9-4974-8799-a762750d0c3f Agent-Session: 42392086-921d-4eab-b427-21748e1316e5
thesiti92
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The context an Ask agent reads before its first question (
askContextinpackages/review/src/review-api/http.ts) now:session_get_instructions({})first (the CLI form for agents without MCP), for the guidelines and each component's fields, and to skip the create-a-review flow since the review exists.Why
Authoring guidance reaches an agent only through
session_get_instructions. An Ask agent answering inline has no reason to call it, so it got none of that guidance; and one asked to edit the review was pointed atsession_editwithout the component reference.The full authoring guide is not inlined: most of it is the review-building workflow, and its
review-source:link format differs from the plainsrc/app.ts:42links the Ask panel opens.Testing
Typecheck clean;
src/askandsrc/review-apitests pass. Not yet exercised in a live Ask session.